Delete a few unused constants

llvm/llvm-project#66576 makes std::string's ctor constexpr if it's short enough to fit in the short-string optimization. This allows the compiler to realize that these are unused. Deleting them is necessary to be able to update libc++. (Relying on std::string's ctor to be constexpr for storage isn't allowed per standard, see discussion on the pull request above.) Bug: none Change-Id: I860e1c67a7c15342901814dafbab262672c0d45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935335 Reviewed-by: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Owners-Override: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1208958}
chromium · Oct 12, 2023 · 879cb86 · 879cb86
1 parent 49427de
commit 879cb86
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 15 deletions.
diff --git a/base/command_line_unittest.cc b/base/command_line_unittest.cc
@@ -34,12 +34,15 @@
 
 namespace base {
 
+#if BUILDFLAG(IS_WIN)
 // To test Windows quoting behavior, we use a string that has some backslashes
 // and quotes.
 // Consider the command-line argument: q\"bs1\bs2\\bs3q\\\"
 // Here it is with C-style escapes.
 static const CommandLine::StringType kTrickyQuoted =
     FILE_PATH_LITERAL("q\\\"bs1\\bs2\\\\bs3q\\\\\\\"");
+#endif
+
 // It should be parsed by Windows as: q"bs1\bs2\\bs3q\"
 // Here that is with C-style escapes.
 static const CommandLine::StringType kTricky =

diff --git a/components/commerce/core/parcel/parcels_server_proxy_unittest.cc b/components/commerce/core/parcel/parcels_server_proxy_unittest.cc
@@ -53,7 +53,6 @@ const std::string kExpectedStopTrackingPostData =
 const std::string kTestTrackingUrl = "www.foo.com";
 const std::string kTestTrackingId = "xyz";
 const std::string kTestSourcePageDomain = "www.abc.com";
-const std::string kDeleteHttpMethod = "DELETE";
 
 std::vector<commerce::ParcelIdentifier> GetTestParcelIdentifiers() {
   commerce::ParcelIdentifier identifier;

diff --git a/components/leveldb_proto/internal/proto_database_impl_unittest.cc b/components/leveldb_proto/internal/proto_database_impl_unittest.cc
@@ -23,7 +23,6 @@ namespace leveldb_proto {
 namespace {
 
 const std::string kDefaultClientName = "client";
-const std::string kDefaultClientName2 = "client_2";
 
 // Example struct defined by clients that can be used instead of protos.
 struct ClientStruct {

diff --git a/components/omnibox/browser/autocomplete_result_unittest.cc b/components/omnibox/browser/autocomplete_result_unittest.cc
@@ -70,17 +70,6 @@ struct AutocompleteMatchTestData {
   AutocompleteMatch::Type type;
 };
 
-const AutocompleteMatchTestData kVerbatimMatches[] = {
-    {"http://search-what-you-typed/",
-     AutocompleteMatchType::SEARCH_WHAT_YOU_TYPED},
-    {"http://url-what-you-typed/", AutocompleteMatchType::URL_WHAT_YOU_TYPED},
-};
-
-const AutocompleteMatchTestData kNonVerbatimMatches[] = {
-    {"http://search-history/", AutocompleteMatchType::SEARCH_HISTORY},
-    {"http://history-title/", AutocompleteMatchType::HISTORY_TITLE},
-};
-
 // Adds |count| AutocompleteMatches to |matches|.
 template <typename T>
 void PopulateAutocompleteMatchesFromTestData(const T* data,

diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
@@ -195,7 +195,6 @@ namespace test_default {
 #include "net/http/transport_security_state_static_unittest_default.h"
 }
 
-const std::u16string kChrome(u"chrome");
 const std::u16string kSecret(u"secret");
 const std::u16string kUser(u"user");
 

diff --git a/storage/browser/blob/blob_memory_controller_unittest.cc b/storage/browser/blob/blob_memory_controller_unittest.cc
@@ -27,7 +27,6 @@ using base::TestSimpleTaskRunner;
 using ItemState = ShareableBlobDataItem::State;
 using QuotaAllocationTask = BlobMemoryController::QuotaAllocationTask;
 
-const std::string kBlobStorageDirectory = "blob_storage";
 const size_t kTestBlobStorageIPCThresholdBytes = 20;
 const size_t kTestBlobStorageMaxSharedMemoryBytes = 50;
 const size_t kTestBlobStorageMaxBlobMemorySize = 500;