Skip to content

Commit

Permalink
[PaymentHandler] Temporarily re-enable identity in IS_READY_TO_PAY
Browse files Browse the repository at this point in the history
Removing identity from IS_READY_TO_PAY turned out to break a native
payment app. This was partially anticipated and we had a reverse Origin
Trial to re-enable it to allow for breakages like this, however the
implementation of it was wrong. Fixing the Origin Trial implementation
is non-trivial (have to plumb data from each renderer through to the
Android code), so this is a quick-fix to just re-enable identity to be
merged back.

(cherry picked from commit 388831e)

Bug: 1427426, 1290492
Change-Id: Ief38b60174ff9172dd44bfcce0d6fc9e71d5082d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369599
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1121725}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4369302
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/branch-heads/5672@{#6}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
  • Loading branch information
stephenmcgruer authored and Krishna Govind committed Mar 24, 2023
1 parent d01b9a3 commit 88831df
Showing 1 changed file with 2 additions and 3 deletions.
Expand Up @@ -261,9 +261,8 @@ public void maybeQueryIsReadyToPayService(Map<String, PaymentMethodData> methodD
/*packageName=*/mPackageName, /*serviceName=*/mIsReadyToPayServiceName,
removeUrlScheme(origin), removeUrlScheme(iframeOrigin), certificateChain,
WebPaymentIntentHelperTypeConverter.fromMojoPaymentMethodDataMap(methodDataMap),
/*clearIdFields=*/
!PaymentFeatureList.isEnabled(
PaymentFeatureList.ADD_IDENTITY_IN_CAN_MAKE_PAYMENT_EVENT));
// TODO(crbug.com/1290492): Re-enable clearing of identity for IS_READY_TO_PAY
/*clearIdFields=*/false);
if (mBypassIsReadyToPayServiceInTest) {
respondToIsReadyToPayQuery(true);
return;
Expand Down

0 comments on commit 88831df

Please sign in to comment.