-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Enabled state of page zoom option on app menu * When the page zoom option is opened from the app menu * When the zoom level is changed from the app menu slider * The zoom level value at slider dismissal when changed, in buckets of 5% in the range from min to max zoom value, currently 50% to 300%. * When the default zoom level is changed from the settings * The default zoom level value at settings closure when changed, in buckets of 5% in the range from min to max zoom value, currently 50% to 300%. Bug: 1232536 Change-Id: I8e00dae78b202cc7681af84972981c06ded99180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3995858 Reviewed-by: Evan Liu <evliu@google.com> Reviewed-by: Mark Schillaci <mschillaci@google.com> Commit-Queue: Amanda Lin Dietz <aldietz@google.com> Cr-Commit-Position: refs/heads/main@{#1067679}
- Loading branch information
Showing
8 changed files
with
264 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
...bility/android/java/src/org/chromium/components/browser_ui/accessibility/PageZoomUma.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| // Copyright 2022 The Chromium Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package org.chromium.components.browser_ui.accessibility; | ||
|
|
||
| import androidx.annotation.IntDef; | ||
| import androidx.annotation.VisibleForTesting; | ||
|
|
||
| import org.chromium.base.metrics.RecordHistogram; | ||
|
|
||
| /** | ||
| * Centralizes UMA data collection for Page Zoom. | ||
| */ | ||
| public class PageZoomUma { | ||
| private static int sMinZoomValue = (int) (PageZoomUtils.PAGE_ZOOM_MINIMUM_ZOOM_LEVEL * 100); | ||
| private static int sMaxZoomValue = (int) (PageZoomUtils.PAGE_ZOOM_MAXIMUM_ZOOM_LEVEL * 100); | ||
| private static int sZoomValueBucketCount = (int) ((sMaxZoomValue - sMinZoomValue) / 5) + 2; | ||
|
|
||
| // AccessibilityPageZoomAppMenuEnabledState defined in tools/metrics/histograms/enums.xml. | ||
| // Add new values before MAX_VALUE. | ||
| // These values are persisted to logs. Entries should not be renumbered and | ||
| // numeric values should never be reused. | ||
| @IntDef({AccessibilityPageZoomAppMenuEnabledState.NOT_ENABLED, | ||
| AccessibilityPageZoomAppMenuEnabledState.USER_ENABLED, | ||
| AccessibilityPageZoomAppMenuEnabledState.OS_ENABLED, | ||
| AccessibilityPageZoomAppMenuEnabledState.MAX_VALUE}) | ||
| public @interface AccessibilityPageZoomAppMenuEnabledState { | ||
| int NOT_ENABLED = 0; | ||
| int USER_ENABLED = 1; | ||
| int OS_ENABLED = 2; | ||
|
|
||
| // Be sure to also update enums.xml when updating these values. | ||
| int MAX_VALUE = 3; | ||
| } | ||
|
|
||
| // Page Zoom histogram values | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | ||
| public static final String PAGE_ZOOM_APP_MENU_ENABLED_STATE_HISTOGRAM = | ||
| "Accessibility.Android.PageZoom.AppMenuEnabledState"; | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | ||
| public static final String PAGE_ZOOM_APP_MENU_SLIDER_OPENED_HISTOGRAM = | ||
| "Accessibility.Android.PageZoom.AppMenuSliderOpened"; | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | ||
| public static final String PAGE_ZOOM_APP_MENU_SLIDER_ZOOM_LEVEL_CHANGED_HISTOGRAM = | ||
| "Accessibility.Android.PageZoom.AppMenuSliderZoomLevelChanged"; | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | ||
| public static final String PAGE_ZOOM_APP_MENU_SLIDER_ZOOM_LEVEL_VALUE_HISTOGRAM = | ||
| "Accessibility.Android.PageZoom.AppMenuSliderZoomLevelValue"; | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | ||
| public static final String PAGE_ZOOM_SETTINGS_DEFAULT_ZOOM_LEVEL_CHANGED_HISTOGRAM = | ||
| "Accessibility.Android.PageZoom.SettingsDefaultZoomLevelChanged"; | ||
| @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE) | ||
| public static final String PAGE_ZOOM_SETTINGS_DEFAULT_ZOOM_LEVEL_VALUE_HISTOGRAM = | ||
| "Accessibility.Android.PageZoom.SettingsDefaultZoomLevelValue"; | ||
|
|
||
| /** | ||
| * Log the enabled state of the page zoom slider option in the app menu. | ||
| * @param value the enum value representing whether the zoom option is not enabled, enabled by | ||
| * the user, or enabled due to the OS font settings. | ||
| */ | ||
| public static void logAppMenuEnabledStateHistogram( | ||
| @AccessibilityPageZoomAppMenuEnabledState int value) { | ||
| RecordHistogram.recordEnumeratedHistogram(PAGE_ZOOM_APP_MENU_ENABLED_STATE_HISTOGRAM, value, | ||
| AccessibilityPageZoomAppMenuEnabledState.MAX_VALUE); | ||
| } | ||
|
|
||
| /** | ||
| * Log that the user opened the slider from the app menu. | ||
| */ | ||
| public static void logAppMenuSliderOpenedHistogram() { | ||
| RecordHistogram.recordBooleanHistogram(PAGE_ZOOM_APP_MENU_SLIDER_OPENED_HISTOGRAM, true); | ||
| } | ||
|
|
||
| /** | ||
| * Log that the user changed the zoom level from the app menu slider. | ||
| */ | ||
| public static void logAppMenuSliderZoomLevelChangedHistogram() { | ||
| RecordHistogram.recordBooleanHistogram( | ||
| PAGE_ZOOM_APP_MENU_SLIDER_ZOOM_LEVEL_CHANGED_HISTOGRAM, true); | ||
| } | ||
|
|
||
| /** | ||
| * Log the value of the zoom level chosen by the user from the app menu slider. | ||
| * @param value the zoom level to log in the form of a double, with 1.0 equivalent to 100%, 1.5 | ||
| * equivalent to 150%, etc. | ||
| */ | ||
| public static void logAppMenuSliderZoomLevelValueHistogram(double value) { | ||
| RecordHistogram.recordLinearCountHistogram( | ||
| PAGE_ZOOM_APP_MENU_SLIDER_ZOOM_LEVEL_VALUE_HISTOGRAM, (int) Math.round(100 * value), | ||
| sMinZoomValue, sMaxZoomValue, sZoomValueBucketCount); | ||
| } | ||
|
|
||
| /** | ||
| * Log that the user changed the default zoom level from the settings page. | ||
| */ | ||
| public static void logSettingsDefaultZoomLevelChangedHistogram() { | ||
| RecordHistogram.recordBooleanHistogram( | ||
| PAGE_ZOOM_SETTINGS_DEFAULT_ZOOM_LEVEL_CHANGED_HISTOGRAM, true); | ||
| } | ||
|
|
||
| /** | ||
| * Log the value of the default zoom level chosen by the user from the settings page. | ||
| * @param value the default zoom level to log in the form of a double, with 1.0 equivalent to | ||
| * 100%, 1.5 equivalent to 150%, etc. | ||
| */ | ||
| public static void logSettingsDefaultZoomLevelValueHistogram(double value) { | ||
| RecordHistogram.recordLinearCountHistogram( | ||
| PAGE_ZOOM_SETTINGS_DEFAULT_ZOOM_LEVEL_VALUE_HISTOGRAM, | ||
| (int) Math.round(100 * value), sMinZoomValue, sMaxZoomValue, sZoomValueBucketCount); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters