-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update autofill keyboard accessory a11y.
The bug is about focus after autofill, but the keyboard accessory has similar default Home focus in other places, this CL tries to address the whole screen reader UX as these places are also related in code. Key points of changes: 1. Put a11y focus on the list of password options (first item) upon opening (was on the Home button) 1.1. Announcement of opened password options (Showing saved passwords and password options) removed, the description of the trigger button is changed to compensate it. 2. Put a11y focus on the active DOM element after closing Password options list and showing keyboard (was on the Home button) 3. Put a11y focus on the active DOM element after autofilling (was on the Home button) Please find these changes in the same order performed in videos: before: http://screencast/cast/NTcwNTQ2NzA1MDMyODA2NHw1MDcxYjVkYi04ZQ after: http://screencast/cast/NDk3MDgxMzc2Njc2MjQ5Nnw1NGNjZjM4Zi04YQ Bug: 1136267 Change-Id: Ibeb1df7bdbb623916797235c9786d63a6daf514f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4129649 Commit-Queue: Dmitry Vykochko <vykochko@google.com> Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1108251}
- Loading branch information
Showing
37 changed files
with
323 additions
and
171 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...rg/chromium/chrome/browser/keyboard_accessory/sheet_tabs/AccessorySheetTabProperties.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Copyright 2023 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
package org.chromium.chrome.browser.keyboard_accessory.sheet_tabs; | ||
|
||
import androidx.recyclerview.widget.RecyclerView; | ||
|
||
import org.chromium.ui.modelutil.PropertyKey; | ||
import org.chromium.ui.modelutil.PropertyModel.ReadableObjectPropertyKey; | ||
import org.chromium.ui.modelutil.PropertyModel.WritableObjectPropertyKey; | ||
|
||
/** | ||
* These properties make up the model of the AccessorySheetTab component. | ||
*/ | ||
class AccessorySheetTabProperties { | ||
static final ReadableObjectPropertyKey<AccessorySheetTabItemsModel> ITEMS = | ||
new ReadableObjectPropertyKey<>("items"); | ||
static final ReadableObjectPropertyKey<RecyclerView.OnScrollListener> SCROLL_LISTENER = | ||
new ReadableObjectPropertyKey<>("scroll_listener"); | ||
static final WritableObjectPropertyKey<Boolean> IS_DEFAULT_A11Y_FOCUS_REQUESTED = | ||
new WritableObjectPropertyKey<>("is_default_a11y_focus_requested"); | ||
|
||
static final PropertyKey[] ALL_KEYS = {ITEMS, SCROLL_LISTENER, IS_DEFAULT_A11Y_FOCUS_REQUESTED}; | ||
|
||
private AccessorySheetTabProperties() {} | ||
} |
Oops, something went wrong.