Skip to content

Commit

Permalink
[Start] Polish ripple effect on the single tab card.
Browse files Browse the repository at this point in the history
Currently, when the user clicks the single tab card, the ripple effect
happens only in the centre of the entire card. In this CL, we extend the
ripple to the entire card.

Before:
https://drive.google.com/file/d/14pM-myu-qwtNJXpHzBiAOz7mdXdnopV9/view?usp=sharing
After:
https://drive.google.com/file/d/1fo95YD6fuMNHSUCFCSJ_ApzILtBcI7_m/view?usp=sharing

(cherry picked from commit f9d5be2)

Bug: 1326255
Change-Id: I51ba8df0429e034274ece3771a6d3093d2a90a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645373
Reviewed-by: Hao Dong <spdonghao@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003996}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652578
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{#77}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
  • Loading branch information
Xi Han authored and Chromium LUCI CQ committed May 18, 2022
1 parent aac0e77 commit 8f15f2e
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
android:layout_marginStart="16dp"
android:layout_marginEnd="16dp"
android:background="@drawable/single_tab_background"
android:foreground="?android:attr/selectableItemBackground"
android:orientation="horizontal">

<RelativeLayout
Expand All @@ -36,7 +37,6 @@
android:layout_height="match_parent"
android:layout_toEndOf="@+id/tab_favicon_view"
android:layout_toStartOf="@+id/chevron_right_view"
android:background="?attr/selectableItemBackground"
android:orientation="vertical">
<TextView
android:id="@+id/tab_switcher_title_description"
Expand Down

0 comments on commit 8f15f2e

Please sign in to comment.