Skip to content

Commit

Permalink
[NTP][Panorama] Add icons/images for rest of Category tiles
Browse files Browse the repository at this point in the history
Add the icons/images for the category tiles that were still missing
them (classic chrome, chrome colors, upload image, and cws).

Screenshots:
screenshot/3WrZ75yckMzCX5x
screenshot/3s8ztdGXMqfnBsA

Bug: 1401486
Change-Id: I35fbeeb38fd57143aff5b72d3bda8d0b02e86117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4112704
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Commit-Queue: Riley Tatum <rtatum@google.com>
Cr-Commit-Position: refs/heads/main@{#1084624}
  • Loading branch information
Riley Tatum authored and Chromium LUCI CQ committed Dec 17, 2022
1 parent 9c44811 commit 8f27ed6
Show file tree
Hide file tree
Showing 5 changed files with 64 additions and 7 deletions.
Expand Up @@ -55,10 +55,14 @@
}
}

.image-container img {
.image-container img,
.image-container div {
position: absolute;
}

.collection img {
height: 100%;
left: 50%;
position: absolute;
top: 0;
transform: translateX(-50%);
}
Expand Down Expand Up @@ -107,6 +111,45 @@
margin-inline-start: 0;
width: 13px;
}

#uploadIcon {
--cr-icon-image: url(icons/upload.svg);
--cr-icon-size: 21px;
height: 21px;
left: 50%;
margin: 0;
top: 50%;
transform: translate(-50%, -50%);
width: 21px;
}

#miniNewTabPage {
left: 12%;
top: 15%;
}

.chrome-color {
height: 50%;
width: 100%;
}

.chrome-color:first-child {
background-color: var(--google-blue-700);
top: 0;
}

.chrome-color:nth-child(2) {
background-color: var(--google-blue-500);
top: 50%;
}

#chromeWebStore {
height: 32px;
left: 50%;
top: 50%;
transform: translate(-50%, -50%);
width: 32px;
}
</style>
<div id="container">
<div id="headerContainer">
Expand All @@ -118,17 +161,23 @@ <h1>$i18n{categoriesHeader}</h1>
<cr-grid columns="6">
<div class="tile" tabindex="0" id="classicChromeTile"
role="button" on-click="onClassicChromeClick_">
<!-- TODO(crbug.com/1384245): add image for classic chrome -->
<div class="image-container"></div>
<div class="image-container">
<img id="miniNewTabPage" src="icons/corner_new_tab_page.svg"></img>
</div>
<div class="label">$i18n{classicChrome}</div>
</div>
<div class="tile" tabindex="0" id="uploadImageTile"
role="button" on-click="onUploadImageClick_">
<div class="image-container"></div>
<div class="image-container">
<div id="uploadIcon" class="cr-icon"></div>
</div>
<div class="label">$i18n{uploadImage}</div>
</div>
<div class="tile" tabindex="0" role="button">
<div class="image-container"></div>
<div class="image-container">
<div class="chrome-color"></div>
<div class="chrome-color"></div>
</div>
<div class="label">$i18n{chromeColors}</div>
</div>
<template is="dom-repeat" id="collectionsRepeat" items="[[collections_]]">
Expand All @@ -145,7 +194,9 @@ <h1>$i18n{categoriesHeader}</h1>
</template>
<div class="tile" tabindex="0" role="button"
on-click="onChromeWebStoreClick_" id="chromeWebStoreTile">
<div class="image-container"></div>
<div class="image-container">
<img id="chromeWebStore" src="icons/chrome_web_store.svg"></img>
</div>
<div class="label">
<div class="cr-icon icon-external"></div>
$i18n{chromeWebStore}
Expand Down
Expand Up @@ -10,7 +10,10 @@ generate_grd("build_grdp") {
grd_prefix = "side_panel_customize_chrome"
out_grd = "$target_gen_dir/resources.grdp"
input_files = [
"chrome_web_store.svg",
"corner_new_tab_page.svg",
"mini_new_tab_page.svg",
"upload.svg",
"uploaded_image.svg",
]
input_files_base_dir = rebase_path(".", "//")
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 8f27ed6

Please sign in to comment.