[ios] Remove ReadingListMessages feature

This change removes the UI-facing implementations of the
ReadingListMessages and TimeToRead features, as they did not gain
significant enough engagement.

Change-Id: Ic3bee829760d83b024b3fbe4950e939d71a75c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3557772
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/main@{#989719}

chrome/browser/flag-metadata.json

@@ -5008,16 +5008,6 @@
     // enabling the feature on every page.
     "expiry_milestone": -1
   },
-  {
-    "name": "reading-list-messages",
-    "owners": [ "thegreenfrog@google.com", "bling-flags@google.com" ],
-    "expiry_milestone": 99
-  },
-  {
-    "name": "reading-list-time-to-read",
-    "owners": [ "thegreenfrog@google.com", "bling-flags@google.com" ],
-    "expiry_milestone": 100
-  },
   {
     "name": "record-snapshot-size",
     "owners": ["edchin","bling-flags@google.com"],

ios/chrome/browser/flags/BUILD.gn

@@ -66,7 +66,6 @@ source_set("flags") {
     "//ios/chrome/browser/ui/ntp:feature_flags",
     "//ios/chrome/browser/ui/overlays/infobar_banner:feature_flags",
     "//ios/chrome/browser/ui/popup_menu/overflow_menu:feature_flags",
-    "//ios/chrome/browser/ui/reading_list:features",
     "//ios/chrome/browser/ui/start_surface:feature_flags",
     "//ios/chrome/browser/ui/tab_switcher/tab_grid:features",
     "//ios/chrome/browser/ui/toolbar_container:feature_flags",

ios/chrome/browser/flags/about_flags.mm

@@ -77,7 +77,6 @@
 #import "ios/chrome/browser/ui/ntp/new_tab_page_feature.h"
 #import "ios/chrome/browser/ui/overlays/infobar_banner/infobar_banner_features.h"
 #import "ios/chrome/browser/ui/popup_menu/overflow_menu/feature_flags.h"
-#import "ios/chrome/browser/ui/reading_list/reading_list_features.h"
 #import "ios/chrome/browser/ui/start_surface/start_surface_features.h"
 #import "ios/chrome/browser/ui/tab_switcher/tab_grid/features.h"
 #import "ios/chrome/browser/ui/toolbar_container/toolbar_container_features.h"
@@ -626,9 +625,6 @@
     {"incognito-ntp-revamp", flag_descriptions::kIncognitoNtpRevampName,
      flag_descriptions::kIncognitoNtpRevampDescription, flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(kIncognitoNtpRevamp)},
-    {"reading-list-messages", flag_descriptions::kReadingListMessagesName,
-     flag_descriptions::kReadingListMessagesDescription, flags_ui::kOsIos,
-     FEATURE_VALUE_TYPE(kReadingListMessages)},
     {"sync-trusted-vault-passphrase-ios-rpc",
      flag_descriptions::kSyncTrustedVaultPassphraseiOSRPCName,
      flag_descriptions::kSyncTrustedVaultPassphraseiOSRPCDescription,
@@ -741,9 +737,6 @@
      flag_descriptions::kLazilyCreateWebStateOnRestorationDescription,
      flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(web::features::kEnableUnrealizedWebStates)},
-    {"reading-list-time-to-read", flag_descriptions::kReadingListTimeToReadName,
-     flag_descriptions::kReadingListTimeToReadDescription, flags_ui::kOsIos,
-     FEATURE_VALUE_TYPE(kReadingListTimeToRead)},
     {"enable-shortened-password-auto-fill-instruction",
      flag_descriptions::kEnableShortenedPasswordAutoFillInstructionName,
      flag_descriptions::kEnableShortenedPasswordAutoFillInstructionDescription,

ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc

@@ -398,16 +398,6 @@ const char kPasswordReuseDetectionDescription[] =
     "Displays warning when user types or pastes a saved password into a "
     "phishing website.";
 
-const char kReadingListMessagesName[] = "Enables Reading List Messages";
-const char kReadingListMessagesDescription[] =
-    "When enabled, a Messages prompt may be presented to allow the user to "
-    "save the current page to Reading List";
-
-const char kReadingListTimeToReadName[] = "Enables Reading List Time To Read";
-const char kReadingListTimeToReadDescription[] =
-    "When enabled, a Time to Read estimate is added to each Reading List "
-    "entry.";
-
 const char kRecordSnapshotSizeName[] =
     "Record the size of image and PDF snapshots in UMA histograms";
 const char kRecordSnapshotSizeDescription[] =

ios/chrome/browser/flags/ios_chrome_flag_descriptions.h

@@ -367,14 +367,6 @@ extern const char kIOSOmniboxUpdatedPopupUIDescription[];
 extern const char kPasswordReuseDetectionName[];
 extern const char kPasswordReuseDetectionDescription[];
 
-// Title and description for the flag to enable the Reading List Messages.
-extern const char kReadingListMessagesName[];
-extern const char kReadingListMessagesDescription[];
-
-// Title and description for the flag to enable Reading List Time to Read.
-extern const char kReadingListTimeToReadName[];
-extern const char kReadingListTimeToReadDescription[];
-
 // Title and description for the flag to native restore web states.
 extern const char kRestoreSessionFromCacheName[];
 extern const char kRestoreSessionFromCacheDescription[];

ios/chrome/browser/infobars/overlays/browser_agent/BUILD.gn

@@ -34,7 +34,6 @@ source_set("browser_agent_util") {
     "//ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/confirm",
     "//ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/passwords",
     "//ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/permissions",
-    "//ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/reading_list",
     "//ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/save_card",
     "//ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/translate",
     "//ios/chrome/browser/main:public",

ios/chrome/browser/infobars/overlays/browser_agent/infobar_overlay_browser_agent_util.mm

@@ -11,7 +11,6 @@
 #import "ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/passwords/password_infobar_interaction_handler.h"
 #import "ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/passwords/update_password_infobar_interaction_handler.h"
 #import "ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/permissions/permissions_infobar_interaction_handler.h"
-#import "ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/reading_list/add_to_reading_list_infobar_interaction_handler.h"
 #import "ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/save_card/save_card_infobar_interaction_handler.h"
 #import "ios/chrome/browser/infobars/overlays/browser_agent/interaction_handlers/translate/translate_infobar_interaction_handler.h"
 
@@ -35,8 +34,6 @@ void AttachInfobarOverlayBrowserAgent(Browser* browser) {
       std::make_unique<SaveCardInfobarInteractionHandler>());
   browser_agent->AddInfobarInteractionHandler(
       std::make_unique<SaveAddressProfileInfobarInteractionHandler>());
-  browser_agent->AddInfobarInteractionHandler(
-      std::make_unique<AddToReadingListInfobarInteractionHandler>(browser));
   browser_agent->AddInfobarInteractionHandler(
       std::make_unique<PermissionsInfobarInteractionHandler>());
 }