-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add CSSTokenizer-created strings to CSSVariableData's backing strings
When computing the value of a registered custom property, we create a CSSVariableData object equivalent to the computed CSSValue by serializing that CSSValue to a String, then tokenizing that value. The problem is that CSSTokenizer can create *new* string objects during the tokenization process (see calls to CSSTokenizer:: RegisterString), without communicating that fact to the call-site. Therefore, this CL adds a way to access those strings so they can be added to the backing strings of the CSSVariableData. Also added a DCHECK to verify that we don't have any tokens with non-backed string pointers. Fixed: 1358907 Change-Id: Ib4585cbb419b616713bb3709c7b81ca1708880ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3892782 Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1046868}
- Loading branch information
Showing
6 changed files
with
66 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters