Skip to content

Commit

Permalink
Remove legacy autofill cvc prompt.
Browse files Browse the repository at this point in the history
This patch removes dead code related to the Legacy Autofill CVC Prompt.

New CVC Prompt Launch bug:
https://launch.corp.google.com/launch/4200485

Fixed: 1379073
Change-Id: I922e789dc4c019eaeae40c1c5a67996cb3e460e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4321090
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Ernesto Izquierdo Clua <eic@google.com>
Cr-Commit-Position: refs/heads/main@{#1115764}
  • Loading branch information
Ernesto Izquierdo Clua authored and Chromium LUCI CQ committed Mar 10, 2023
1 parent bbf2b26 commit 934c7c8
Show file tree
Hide file tree
Showing 20 changed files with 6 additions and 1,620 deletions.
6 changes: 0 additions & 6 deletions ios/chrome/browser/flags/about_flags.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1122,12 +1122,6 @@
flag_descriptions::kAutofillParseIBANFieldsName,
flag_descriptions::kAutofillParseIBANFieldsDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(autofill::features::kAutofillParseIBANFields)},
{"autofill-enable-new-card-unmask-prompt-view",
flag_descriptions::kAutofillEnableNewCardUnmaskPromptViewName,
flag_descriptions::kAutofillEnableNewCardUnmaskPromptViewDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(
autofill::features::kAutofillEnableNewCardUnmaskPromptView)},
{"omnibox-zero-suggest-prefetching",
flag_descriptions::kOmniboxZeroSuggestPrefetchingName,
flag_descriptions::kOmniboxZeroSuggestPrefetchingDescription,
Expand Down
6 changes: 0 additions & 6 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@ const char kAutofillCreditCardUploadDescription[] =
"Offers uploading Autofilled credit cards to Google Payments after form "
"submission.";

const char kAutofillEnableNewCardUnmaskPromptViewName[] =
"Enable the new Card Unmask Prompt View for Autofill.";
const char kAutofillEnableNewCardUnmaskPromptViewDescription[] =
"Displays the new autofill prompt for entering a credit card's CVC and "
"(optional) expiration date.";

const char kAutofillEnableRankingFormulaAddressProfilesName[] =
"Enable new Autofill suggestion ranking formula for address profiles";
const char kAutofillEnableRankingFormulaAddressProfilesDescription[] =
Expand Down
5 changes: 0 additions & 5 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ extern const char kAutofillBrandingIOSDescription[];
extern const char kAutofillCreditCardUploadName[];
extern const char kAutofillCreditCardUploadDescription[];

// Title and description for the flag to enable the new Card Unmask Prompt View
// in Autofill.
extern const char kAutofillEnableNewCardUnmaskPromptViewName[];
extern const char kAutofillEnableNewCardUnmaskPromptViewDescription[];

// Title and description for the flag to control the new autofill suggestion
// ranking formula for address profiles.
extern const char kAutofillEnableRankingFormulaAddressProfilesName[];
Expand Down
22 changes: 2 additions & 20 deletions ios/chrome/browser/ui/autofill/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,8 @@ source_set("autofill") {
frameworks = [ "UIKit.framework" ]
}

# TODO(crbug.com/1344830): Migrate away from deprecated MDC APIs.
config("disable_deprecated_declarations") {
cflags = [ "-Wno-deprecated-declarations" ]
}

source_set("bridges") {
configs += [
":disable_deprecated_declarations",
"//build/config/compiler:enable_arc",
]
configs += [ "//build/config/compiler:enable_arc" ]
sources = [
"card_expiration_date_fix_flow_view_bridge.h",
"card_expiration_date_fix_flow_view_bridge.mm",
Expand All @@ -83,32 +75,22 @@ source_set("bridges") {
"card_unmask_prompt_view_controller.mm",
"create_card_unmask_prompt_view_bridge.h",
"create_card_unmask_prompt_view_bridge.mm",
"legacy_card_unmask_prompt_view_bridge.h",
"legacy_card_unmask_prompt_view_bridge.mm",
]
deps = [
":autofill_ui",
":features",
"//base",
"//components/autofill/core/browser",
"//components/strings",
"//ios/chrome/browser/net:crurl",
"//ios/chrome/browser/shared/ui/util",
"//ios/chrome/browser/ui/autofill/cells",
"//ios/chrome/browser/ui/collection_view/cells",
"//ios/chrome/browser/ui/list_model",
"//ios/chrome/browser/ui/table_view:utils",
"//ios/chrome/browser/ui/table_view/cells",
"//ios/chrome/common/ui/colors",
"//ios/third_party/material_components_ios",
"//ios/web",
"//ui/base",
"//url",
]
public_deps = [
"//ios/chrome/browser/ui/collection_view",
"//ios/chrome/browser/ui/table_view",
]
public_deps = [ "//ios/chrome/browser/ui/table_view" ]
frameworks = [ "UIKit.framework" ]
}

Expand Down
17 changes: 1 addition & 16 deletions ios/chrome/browser/ui/autofill/cells/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,42 +13,31 @@ source_set("cells") {
"autofill_edit_item.mm",
"cvc_header_item.h",
"cvc_header_item.mm",
"cvc_item+private.h",
"cvc_item.h",
"cvc_item.mm",
"expiration_date_edit_item+private.h",
"expiration_date_edit_item.h",
"expiration_date_edit_item.mm",
"expiration_date_edit_item_delegate.h",
"legacy_autofill_edit_item.h",
"legacy_autofill_edit_item.mm",
"status_item.h",
"status_item.mm",
"target_account_item.h",
"target_account_item.mm",
]

deps = [
"//base",
"//build:branding_buildflags",
"//components/autofill/core/common:features",
"//components/resources",
"//components/resources:components_scaled_resources_grit",
"//components/strings",
"//ios/chrome/app/strings",
"//ios/chrome/app/theme",
"//ios/chrome/browser/shared/public/features",
"//ios/chrome/browser/shared/ui/util",
"//ios/chrome/browser/ui/autofill:autofill_ui",
"//ios/chrome/browser/ui/autofill:autofill_ui_type",
"//ios/chrome/browser/ui/collection_view/cells",
"//ios/chrome/browser/ui/ntp:logo",
"//ios/chrome/browser/ui/table_view:styler",
"//ios/chrome/browser/ui/table_view/cells",
"//ios/chrome/common/ui/colors",
"//ios/chrome/common/ui/table_view:cells_constants",
"//ios/chrome/common/ui/util",
"//ios/public/provider/chrome/browser/ui_utils:ui_utils_api",
"//ios/third_party/material_components_ios",
"//ui/base",
]

Expand All @@ -62,18 +51,14 @@ source_set("unit_tests") {
testonly = true
sources = [
"cvc_header_item_unittest.mm",
"cvc_item_unittest.mm",
"expiration_date_edit_item_unittest.mm",
"legacy_autofill_edit_item_unittest.mm",
"status_item_unittest.mm",
]

deps = [
":cells",
"//base",
"//components/resources",
"//ios/chrome/browser/ui/autofill:autofill_ui",
"//ios/chrome/browser/ui/collection_view/cells",
"//ios/chrome/browser/ui/table_view:styler",
"//ios/third_party/material_components_ios",
"//testing/gtest",
Expand Down
13 changes: 0 additions & 13 deletions ios/chrome/browser/ui/autofill/cells/cvc_item+private.h

This file was deleted.

77 changes: 0 additions & 77 deletions ios/chrome/browser/ui/autofill/cells/cvc_item.h

This file was deleted.

0 comments on commit 934c7c8

Please sign in to comment.