Skip to content

Commit

Permalink
[iOS][omnibox] Expose two flags in iOS about://flags.
Browse files Browse the repository at this point in the history
OmniboxReportAssistedQueryStats, OmniboxReportSearchboxStats are flags
that are experimented with on iOS, so they should be available for
manual switching.

Bug: none
Change-Id: Ia1b26d02d1dc74850f727dd891551cb42a93ce0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192144
Reviewed-by: Christian Xu <christianxu@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/5481@{#620}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
  • Loading branch information
Stepan Khapugin authored and Chromium LUCI CQ committed Jan 24, 2023
1 parent 3d31915 commit 95ba452
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 0 deletions.
8 changes: 8 additions & 0 deletions ios/chrome/browser/flags/about_flags.mm
Expand Up @@ -790,6 +790,14 @@
flag_descriptions::kOmniboxFocusTriggersSRPZeroSuggestDescription,
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(omnibox::kFocusTriggersSRPZeroSuggest)},
{"omnibox-report-assisted-query-stats",
flag_descriptions::kOmniboxReportAssistedQueryStatsName,
flag_descriptions::kOmniboxReportAssistedQueryStatsDescription,
flags_ui::kOsIos, FEATURE_VALUE_TYPE(omnibox::kReportAssistedQueryStats)},
{"omnibox-report-searchbox-stats",
flag_descriptions::kOmniboxReportSearchboxStatsName,
flag_descriptions::kOmniboxReportSearchboxStatsDescription,
flags_ui::kOsIos, FEATURE_VALUE_TYPE(omnibox::kReportSearchboxStats)},
{"omnibox-fuzzy-url-suggestions",
flag_descriptions::kOmniboxFuzzyUrlSuggestionsName,
flag_descriptions::kOmniboxFuzzyUrlSuggestionsDescription,
Expand Down
12 changes: 12 additions & 0 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
Expand Up @@ -601,6 +601,18 @@ const char kOmniboxLocalHistoryZeroSuggestBeyondNTPDescription[] =
"Enables local history zero-prefix suggestions in every context in which "
"the remote zero-prefix suggestions are enabled.";

const char kOmniboxReportAssistedQueryStatsName[] =
"Omnibox Assisted Query Stats param";
const char kOmniboxReportAssistedQueryStatsDescription[] =
"Enables reporting the Assisted Query Stats param in search destination "
"URLs originated from the Omnibox.";

const char kOmniboxReportSearchboxStatsName[] =
"Omnibox Searchbox Stats proto param";
const char kOmniboxReportSearchboxStatsDescription[] =
"Enables reporting the serialized Searchbox Stats proto param in search "
"destination URLs originated from the Omnibox.";

const char kOmniboxZeroSuggestPrefetchingName[] =
"Omnibox Zero Prefix Suggestion Prefetching on NTP";
const char kOmniboxZeroSuggestPrefetchingDescription[] =
Expand Down
8 changes: 8 additions & 0 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
Expand Up @@ -518,6 +518,14 @@ extern const char kOmniboxOnFocusSuggestionsDescription[];
extern const char kOmniboxMaxURLMatchesName[];
extern const char kOmniboxMaxURLMatchesDescription[];

// Title and description for assisted query stats param reporting.
extern const char kOmniboxReportAssistedQueryStatsName[];
extern const char kOmniboxReportAssistedQueryStatsDescription[];

// Title and description for searchbox stats flag.
extern const char kOmniboxReportSearchboxStatsName[];
extern const char kOmniboxReportSearchboxStatsDescription[];

// Title and description for the flag to swap Omnibox Textfield implementation
// to a new experimental one.
extern const char kOmniboxNewImplementationName[];
Expand Down

0 comments on commit 95ba452

Please sign in to comment.