Skip to content

Commit

Permalink
[Refresh] (Merge to Chromium 116) Apply tab background color for inac…
Browse files Browse the repository at this point in the history
…tive tabs.

(cherry picked from commit 5c4801d)

Bug: 1442904
Change-Id: I5942d436df9ad65e5cce7d100dbacf19717f124a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4735606
Commit-Queue: Shibalik Mohapatra <shibalik@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: David Pennington <dpenning@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1177939}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4761085
Cr-Commit-Position: refs/branch-heads/5845@{#1281}
Cr-Branched-From: 5a5dff6-refs/heads/main@{#1160321}
  • Loading branch information
Shibalik Mohapatra authored and Chromium LUCI CQ committed Aug 8, 2023
1 parent cba149f commit 970ced0
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions chrome/browser/ui/views/tabs/tab_style_views.cc
Original file line number Diff line number Diff line change
Expand Up @@ -990,8 +990,6 @@ class ChromeRefresh2023TabStyleViews : public GM2TabStyleViews {
TabStyle::RenderUnits::kPixels) const override;
void PaintBackgroundHover(gfx::Canvas* canvas, float scale) const override;
SkColor GetTabSeparatorColor() const override;
bool ShouldPaintTabBackgroundColor(TabActive active,
bool has_custom_background) const override;

protected:
float GetSeparatorOpacity(bool for_layout, bool leading) const override;
Expand Down Expand Up @@ -1118,14 +1116,6 @@ SkColor ChromeRefresh2023TabStyleViews::GetTabSeparatorColor() const {
: kColorTabDividerFrameInactive);
}

bool ChromeRefresh2023TabStyleViews::ShouldPaintTabBackgroundColor(
TabActive active,
bool has_custom_background) const {
return (tab()->IsActive() || tab()->IsSelected()) &&
GM2TabStyleViews::ShouldPaintTabBackgroundColor(active,
has_custom_background);
}

float ChromeRefresh2023TabStyleViews::GetSeparatorOpacity(bool for_layout,
bool leading) const {
const auto has_visible_background = [](const Tab* const tab) {
Expand Down

0 comments on commit 970ced0

Please sign in to comment.