Skip to content

Commit

Permalink
[FSA] Update file_system_site_entry element format
Browse files Browse the repository at this point in the history
Updates the file system Site Settings UI
`file_system_site_entry` element to match the approved UX
mockup in terms of element spacing and layout on the page, while also
matching the layout of the similar `category_setting_exceptions`
element, which appears directly above it.

This cleanup is a required part of the FSA Persistent Permissions
feature implementation.

Screenshot: https://screenshot.googleplex.com/TwJERJCR82nQagU
Bug: 1011533
Change-Id: If7730552b8e650032f6e49141ed74b30962b7367
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4969361
Auto-Submit: Christine Smith <christinesm@chromium.org>
Reviewed-by: Rainhard Findling <rainhard@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1216851}
  • Loading branch information
christine-hollingsworth authored and Chromium LUCI CQ committed Oct 30, 2023
1 parent 0799e35 commit 983c86f
Showing 1 changed file with 17 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,18 +1,30 @@
<style include="cr-shared-style settings-shared">
.origin {
flex-grow: 1;
padding-inline-start: 20px;
}

.origin-row {
align-items: center;
display: flex;
margin-left: auto;
padding-right: 0.5em;
padding-bottom: 5px;
padding-inline-end: 10px;
padding-top: 5px;
}

.subpage-arrow {
margin-inline-end: 2px;
}

.separator {
padding-inline-end: 25px;
}
</style>

<div class="list-frame">
<div class="origin-row">
<site-favicon url="[[grantsPerOrigin.origin]]"></site-favicon>
<div class="cr-row">
[[grantsPerOrigin.origin]]
</div>
<div class="origin">[[grantsPerOrigin.origin]]</div>
<cr-icon-button id="fileSystemSiteDetails"
class="subpage-arrow"
aria-label$="[[grantsPerOrigin.origin]]"
Expand Down

0 comments on commit 983c86f

Please sign in to comment.