Skip to content

Commit

Permalink
Remove HostedAppFrame.WrenchMenu.MenuAction
Browse files Browse the repository at this point in the history
The histogram HostedAppFrame.WrenchMenu.MenuAction expired in M90
and is redundant.

WrenchMenu.MenuAction remains and is sufficient.

Bug: 1165069
Change-Id: I2d9f5e3942ff3319ad4dc38a06826b4e5c2edfb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4095598
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084849}
  • Loading branch information
ericwilligers authored and Chromium LUCI CQ committed Dec 19, 2022
1 parent 1d5e01b commit 995423c
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 19 deletions.
2 changes: 0 additions & 2 deletions chrome/browser/ui/web_applications/web_app_browsertest.cc
Expand Up @@ -976,8 +976,6 @@ IN_PROC_BROWSER_TEST_F(WebAppBrowserTest, MAYBE_UninstallMenuOption) {
base::HistogramTester tester;
app_menu_model->ExecuteCommand(WebAppMenuModel::kUninstallAppCommandId,
/*event_flags=*/0);
tester.ExpectUniqueSample("HostedAppFrame.WrenchMenu.MenuAction",
MENU_ACTION_UNINSTALL_APP, 1);
tester.ExpectUniqueSample("WrenchMenu.MenuAction", MENU_ACTION_UNINSTALL_APP,
1);
#endif // BUILDFLAG(IS_CHROMEOS)
Expand Down
6 changes: 0 additions & 6 deletions chrome/browser/ui/web_applications/web_app_menu_model.cc
Expand Up @@ -175,9 +175,3 @@ void WebAppMenuModel::Build() {
AddSeparator(ui::LOWER_SEPARATOR);
CreateCutCopyPasteMenu();
}

void WebAppMenuModel::LogMenuAction(AppMenuAction action_id) {
AppMenuModel::LogMenuAction(action_id);
UMA_HISTOGRAM_ENUMERATION("HostedAppFrame.WrenchMenu.MenuAction", action_id,
LIMIT_MENU_ACTION);
}
1 change: 0 additions & 1 deletion chrome/browser/ui/web_applications/web_app_menu_model.h
Expand Up @@ -31,7 +31,6 @@ class WebAppMenuModel : public AppMenuModel {
protected:
// AppMenuModel:
void Build() override;
void LogMenuAction(AppMenuAction action_id) override;

private:
#if BUILDFLAG(IS_CHROMEOS_ASH)
Expand Down
10 changes: 0 additions & 10 deletions tools/metrics/histograms/metadata/others/histograms.xml
Expand Up @@ -7016,16 +7016,6 @@ chromium-metrics-reviews@google.com.
</summary>
</histogram>

<histogram name="HostedAppFrame.WrenchMenu.MenuAction" enum="WrenchMenuAction"
expires_after="M90">
<owner>calamity@chromium.org</owner>
<owner>alancutter@chromium.org</owner>
<summary>
Number of times that each menu item is clicked from the hosted app window
menu button.
</summary>
</histogram>

<histogram name="Hwsec.Attestation.PrepareDuration" units="ms"
expires_after="2023-04-23">
<owner>chingkang@chromium.org</owner>
Expand Down

0 comments on commit 995423c

Please sign in to comment.