-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "ax_ui: make AXPosition keeping an anchor as an AXNode instance"
This is a reland of commit 86543a2 The original CL made the browser to crash because AXPlatformNodeTextRangeProviderWin failed to remove itself from AXTree observers, see crbug.com/1394743. After crrev.com/c/4122368 is landed the crash should be no issue anymore. Original change's description: > ax_ui: make AXPosition keeping an anchor as an AXNode instance > > Change-Id: I7ae44cbcd789683715fc3fd32e832ed100845e2b > Bug: 1362839 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3989063 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Alexander Surkkov <asurkov@igalia.com> > Cr-Commit-Position: refs/heads/main@{#1076372} Bug: 1362839 Change-Id: I5c7863ca788057d9f1ce93418a1df0dec6a33ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4111760 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by: Jacques Newman <janewman@microsoft.com> Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1100434}
- Loading branch information
Showing
2 changed files
with
50 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters