-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fenced frames: Update Shared Storage browser tests to test
`selectURL()` that returns a FencedFrameConfig. crrev.com/c/4111682 enables `selectURL()` to return a FencedFrameConfig object by specifying the new boolean dictionary member in SharedStorageRunOperationMethodOptions as true. This CL updates the test cases in 1. shared_storage/shared_storage_browsertest.cc 2. storage/shared_storage_browsertest.cc to test this new behavior. A test-only observer is added to observe 1. the generated urn::uuid. 2. the populated FencedFrameConfig. It's needed because we cannot obtained the urn::uuid from the returned FencedFrameConfig object. It is designed to be opaque to the web platform. For example: const fenced_frame_config = await sharedStorage.selectURL(...); const urn = fenced_frame_config.urn; // Cannot do this Bug: 1347953 Change-Id: Id580664ab029e4337041ca69911353c1b90c2929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4127118 Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1106897}
- Loading branch information
1 parent
a40ae84
commit 9c4ed28
Showing
14 changed files
with
2,104 additions
and
655 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.