Skip to content

Commit

Permalink
Revert "WebUI: Update several toolchain dependencies to latest versio…
Browse files Browse the repository at this point in the history
…ns."

This reverts commit aca5179.

Reason for revert: 

May cause failures in https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/8328/overview

Original change's description:
> WebUI: Update several toolchain dependencies to latest versions.
>
> Specifically updating:
>  - svgo: 2.8.0  -> 3.0.2
>    Includes a fix for [1] which was affecting some SVG files, and has
>    resulted in using 'minifyStyles: false' in
>    tools/resources/svgo.config.js as a workaround, see [2].
>  - terser: 5.16.2 -> 5.20.0
>  - rollup: 3.12.0 -> 3.29.4
>  - eslint: 8.33.0 -> 8.50.0
>
> With the latest version of Rollup, bundled files are unfortunately a
> bit larger, due to fixing a previous bug [3], which incorrectly only
> kept the first line of all license header comments. The new behavior
> is correct, so perhaps we should look into ways of deduplicating license
> header comments in the future, to further reduce the file size.
>
> [1] svg/svgo#1672
> [2] https://source.chromium.org/chromium/chromium/src/+/main:tools/resources/svgo.config.js;l=17-18;drc=4046a6ad0dfa25c3ec4ff3a0f2019badcd4ede70
> [3] rollup/rollup#4953
>
> Bug: None
> Change-Id: I08fc9a6ad0cf37e75e0b5e3c4dcc61f4ad555838
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903168
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1204162}

Bug: None
Change-Id: I168e5d1a7f15b339dda21299698af046d30f5adf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4908630
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Jian Li <jianli@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1204278}
  • Loading branch information
jianli-chromium authored and Chromium LUCI CQ committed Oct 2, 2023
1 parent 5945f34 commit 9e2f8c6
Show file tree
Hide file tree
Showing 3 changed files with 313 additions and 387 deletions.
2 changes: 1 addition & 1 deletion third_party/node/node_modules.tar.gz.sha1
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ddc7cddc319ae5689ebf2c927e284814f2892e47
937cea04689b7b8dcf3cb9adbb12c79d1d6c38bb

0 comments on commit 9e2f8c6

Please sign in to comment.