Skip to content

Commit

Permalink
Revert "Implement ExecuteHttpRequest on Chrome OS"
Browse files Browse the repository at this point in the history
This reverts commit 0d10684.

Reason for revert:
Findit (https://goo.gl/kROfz5) identified this CL at revision 0d10684 as
the culprit for failures in the continuous build including:

Sample Failed Build: https://ci.chromium.org/b/8814587706848908497
Sample Failed Step: compile

If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2F0d10684dd220aacb639a4a2d5c83b7feacef456f&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+0d10684dd220aacb639a4a2d5c83b7feacef456f

Original change's description:
> Implement ExecuteHttpRequest on Chrome OS
> 
> This implements the Chrome OS side of ExecuteHttpRequest which handles
> HTTP requests on behalf of DriveFS. This is mostly a simple bridge,
> between DriveFS's HttpDelegate and a URLLoader.
> 
> Bug: b:201774934
> Change-Id: Ia497a8b76eabceca0566dd4dc1644b8ad8c17ae3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3583027
> Commit-Queue: Travis Lane <travislane@google.com>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Austin Tankiang <austinct@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1001316}


Change-Id: I8a3a6db7cd7ecbd879dce75082e975f7f2d400a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:201774934
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3635634
Reviewed-by: Jit Yao Yap <jityao@google.com>
Commit-Queue: Jit Yao Yap <jityao@google.com>
Owners-Override: Jit Yao Yap <jityao@google.com>
Cr-Commit-Position: refs/heads/main@{#1001324}
  • Loading branch information
Findit authored and Chromium LUCI CQ committed May 10, 2022
1 parent e111f91 commit 9e971a0
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 590 deletions.
3 changes: 0 additions & 3 deletions ash/components/drivefs/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ component("drivefs") {
"drivefs_host.cc",
"drivefs_host.h",
"drivefs_host_observer.h",
"drivefs_http_client.cc",
"drivefs_http_client.h",
"drivefs_search.cc",
"drivefs_search.h",
"drivefs_session.cc",
Expand Down Expand Up @@ -75,7 +73,6 @@ source_set("unit_tests") {
"drivefs_auth_unittest.cc",
"drivefs_bootstrap_unittest.cc",
"drivefs_host_unittest.cc",
"drivefs_http_client_unittest.cc",
"drivefs_search_unittest.cc",
"drivefs_session_unittest.cc",
]
Expand Down
10 changes: 0 additions & 10 deletions ash/components/drivefs/drivefs_host.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

#include "ash/components/drivefs/drivefs_bootstrap.h"
#include "ash/components/drivefs/drivefs_host_observer.h"
#include "ash/components/drivefs/drivefs_http_client.h"
#include "ash/components/drivefs/drivefs_search.h"
#include "ash/constants/ash_features.h"
#include "base/bind.h"
Expand Down Expand Up @@ -56,8 +55,6 @@ class DriveFsHost::MountState : public DriveFsSession,
bool{host->account_token_delegate_->GetCachedAccessToken()};
search_ = std::make_unique<DriveFsSearch>(
drivefs_interface(), host_->network_connection_tracker_, host_->clock_);
http_client_ = std::make_unique<DriveFsHttpClient>(
host_->delegate_->GetURLLoaderFactory());
}

MountState(const MountState&) = delete;
Expand Down Expand Up @@ -181,12 +178,6 @@ class DriveFsHost::MountState : public DriveFsSession,
std::move(callback), mojom::DialogResult::kNotDisplayed));
}

void ExecuteHttpRequest(
mojom::HttpRequestPtr request,
mojo::PendingRemote<mojom::HttpDelegate> delegate) override {
http_client_->ExecuteHttpRequest(std::move(request), std::move(delegate));
}

// DriveNotificationObserver overrides:
void OnNotificationReceived(
const std::map<std::string, int64_t>& invalidations) override {
Expand All @@ -207,7 +198,6 @@ class DriveFsHost::MountState : public DriveFsSession,
DriveFsHost* const host_;

std::unique_ptr<DriveFsSearch> search_;
std::unique_ptr<DriveFsHttpClient> http_client_;

bool token_fetch_attempted_ = false;
bool team_drives_fetched_ = false;
Expand Down
222 changes: 0 additions & 222 deletions ash/components/drivefs/drivefs_http_client.cc

This file was deleted.

37 changes: 0 additions & 37 deletions ash/components/drivefs/drivefs_http_client.h

This file was deleted.

0 comments on commit 9e971a0

Please sign in to comment.