Skip to content

Commit

Permalink
Revert "crosier: Port login.Chrome and login.ChromeGaia"
Browse files Browse the repository at this point in the history
This reverts commit 4ca35db.

Reason for revert: Build failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/lacros-amd64-generic-rel-non-skylab

Original change's description:
> crosier: Port login.Chrome and login.ChromeGaia
>
> - Add `ChromeOSIntegrationLoginMixIn` that provides login support
>   - It provides 3 login modes:
>     - kStubLogin: Login like browser tests, Good for tests only need to
>       verify chrome states.
>     - kTestLogin: Login using oobe test api, same as tast's default
>       login. Good for test that needs to simulate real login but do
>       not need Gaia ideneity;
>     - kGaiaLogin: Login using Gaia like production chrome.
> - Implement login integration tests that exercise kTestLogin
>   (login.Chrome) and kGaiaLogin (login.ChromeGaia).
>
> Bug: b:301445988
> Change-Id: If4d3bd0450058ff46b60539b4a12738e7bb88279
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4953973
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Reviewed-by: Brett Wilson <brettw@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1212847}

Bug: b:301445988
Change-Id: I77ee20f960ca409c5c9c3c2518176028c32ab008
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4959256
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Owners-Override: Thomas Guilbert <tguilbert@chromium.org>
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1212863}
  • Loading branch information
tguilbert-google authored and Chromium LUCI CQ committed Oct 20, 2023
1 parent 2dd42d7 commit 9ebae86
Show file tree
Hide file tree
Showing 9 changed files with 63 additions and 403 deletions.
59 changes: 0 additions & 59 deletions chrome/browser/ash/login/login_integration_test.cc

This file was deleted.

4 changes: 0 additions & 4 deletions chrome/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,6 @@ static_library("test_support") {

if (is_chromeos && is_chromeos_device) {
sources += [
"base/chromeos/crosier/chromeos_integration_login_mixin.cc",
"base/chromeos/crosier/chromeos_integration_login_mixin.h",
"base/chromeos/crosier/chromeos_integration_test_mixin.cc",
"base/chromeos/crosier/chromeos_integration_test_mixin.h",
"base/chromeos/crosier/chromeos_test_launcher.cc",
Expand Down Expand Up @@ -1045,7 +1043,6 @@ if (is_chromeos && is_chromeos_device) {
"../browser/ash/external_metrics_integration_test.cc",
"../browser/ash/featured_integration_test.cc",
"../browser/ash/login/lock/lock_screen_integration_test.cc",
"../browser/ash/login/login_integration_test.cc",
"../browser/ash/ml_integration_test.cc",
"../browser/ash/screenshot_integration_test.cc",
"../browser/ui/ash/app_list/app_list_integration_test.cc",
Expand All @@ -1066,7 +1063,6 @@ if (is_chromeos && is_chromeos_device) {
}

deps += [
"//chrome/browser/ash:test_support",
"//chrome/test/base/chromeos/crosier:proto",
"//chrome/test/base/chromeos/crosier/helper:common",
"//chromeos/ash/components/standalone_browser",
Expand Down
230 changes: 0 additions & 230 deletions chrome/test/base/chromeos/crosier/chromeos_integration_login_mixin.cc

This file was deleted.

This file was deleted.

0 comments on commit 9ebae86

Please sign in to comment.