Skip to content

Commit

Permalink
Document how to find fallback clang version numbers for Rust builds.
Browse files Browse the repository at this point in the history
R=collinbaker@chromium.org

Bug: 1401042
Change-Id: I822926ecd50b199378aaff0194b1b6ea1d82e6c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4111773
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1084505}
  • Loading branch information
danakj authored and Chromium LUCI CQ committed Dec 16, 2022
1 parent b996d6b commit 9ff4066
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions tools/rust/update_rust.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
CRUBIT_SUB_REVISION = 1

# TODO(crbug.com/1401042): Set this back to None once Clang rolls block on Rust
# building. Until Clang rolls block on Rust, they frequently roll without a
# Rust compiler, which causes developer machines/bots to 404 in gclient sync.
# building. Until Clang rolls block on Rust, they frequently roll without a Rust
# compiler, which causes developer machines/bots to 404 in gclient sync.
#
# If not None, use a Rust package built with an older LLVM version than
# specified in tools/clang/scripts/update.py. This is a fallback for when an
Expand All @@ -49,6 +49,10 @@
# This should almost always be None. When a breakage happens the fallback should
# be temporary. Once fixed, the applicable revision(s) above should be updated
# and FALLBACK_CLANG_VERSION should be reset to None.
#
# Rust builds (for Linux) that worked are found at:
# https://commondatastorage.googleapis.com/chromium-browser-clang/index.html?path=Linux_x64/rust-toolchain-
# The latest builds are prefixed with a date, such as `20230101-1`.
FALLBACK_CLANG_VERSION = 'llvmorg-16-init-13328-g110fe4f4-1'

# Hash of src/stage0.json, which itself contains the stage0 toolchain hashes.
Expand Down

0 comments on commit 9ff4066

Please sign in to comment.