-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "Resize sign out button when it's too long."
This is a reland of 181414e The original change was reverted by: https://chromium-review.googlesource.com/c/chromium/src/+/1085067 > ==20322==ERROR: LeakSanitizer: detected memory leaks > Direct leak of 496 byte(s) in 1 object(s) allocated from: > #0 0x69b3d2 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 > #1 0x65a6dca in ash::TopShortcutsView::TopShortcutsView(ash::UnifiedSystemTrayController*) ash/system/unified/top_shortcuts_view.cc:130:43 Original change's description: > Resize sign out button when it's too long. > > Limits the size of the sign-out / sign-out-all button to keep other > buttons and minimum spacing in the parent view. This is needed because > the translated text resource can be very long. Also adding description > for such text resources to keep them shorter in the next revision. > > Bug: 847100 > Change-Id: I8fc79b0b0d3eb661553323a2d9f094f02320fa0a > Reviewed-on: https://chromium-review.googlesource.com/1080364 > Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564016} Bug: 847100 Change-Id: Ic2641bf8d61d837c56072988033f68f31f3d5da8 Reviewed-on: https://chromium-review.googlesource.com/1085327 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564796}
- Loading branch information
Tatsuhisa Yamaguchi
authored and
Commit Bot
committed
Jun 6, 2018
1 parent
70fa259
commit a059207
Showing
3 changed files
with
50 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters