Skip to content

Commit

Permalink
Fix failing DataDrivenHeuristics/AllForms.109 test
Browse files Browse the repository at this point in the history
The heuristic here expects the current and two following years:
https://source.chromium.org/chromium/chromium/src/+/main:components/autofill/core/browser/form_parsing/credit_card_field.cc;l=368;drc=b1873cad20e18ff8afc0db995c4ac580ba051e42

(cherry picked from commit f147dde)

Fixed: 1404366
Change-Id: I8bfa521f4acf9d7ff8bf9610659e62953ec382ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4128297
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Owners-Override: Greg Thompson <grt@google.com>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1087982}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4136432
Auto-Submit: Christoph Schwering <schwering@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#128}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
  • Loading branch information
Dominic Battre authored and Chromium LUCI CQ committed Jan 4, 2023
1 parent 85dadf0 commit a1c66df
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ <h4 >Amount</h4>
<legend>
<b>Expiration Date</b>
</legend>
<select data-ng-model="enteredCreditCardInfo.selectedMonth" data-ng-options="m.Id as m.Name for m in creditMonthList" client-validation="onExit" data-required-on-exit="" data-subsection="creditCard"><option value="" class="">Month</option><option value="0">01 January</option><option value="1">02 February</option><option value="2">03 March</option><option value="3">04 April</option><option value="4">05 May</option><option value="5">06 June</option><option value="6">07 July</option><option value="7">08 August</option><option value="8">09 September</option><option value="9">10 October</option><option value="10">11 November</option><option value="11">12 December</option></select><select class="credit-year ng-pristine ng-valid" data-ng-model="enteredCreditCardInfo.selectedYear" data-ng-options="year for year in creditYearList" client-validation="onExit" data-required-on-exit="" data-subsection="creditCard"><option value="" class="">Year</option><option value="0">2014</option><option value="1">2015</option><option value="2">2016</option><option value="3">2017</option><option value="4">2018</option><option value="5">2019</option><option value="6">2020</option><option value="7">2021</option><option value="8">2022</option><option value="9">2023</option><option value="10">2024</option></select><span class="missing">Please enter the expiration date.</span>
<select data-ng-model="enteredCreditCardInfo.selectedMonth" data-ng-options="m.Id as m.Name for m in creditMonthList" client-validation="onExit" data-required-on-exit="" data-subsection="creditCard"><option value="" class="">Month</option><option value="0">01 January</option><option value="1">02 February</option><option value="2">03 March</option><option value="3">04 April</option><option value="4">05 May</option><option value="5">06 June</option><option value="6">07 July</option><option value="7">08 August</option><option value="8">09 September</option><option value="9">10 October</option><option value="10">11 November</option><option value="11">12 December</option></select><select class="credit-year ng-pristine ng-valid" data-ng-model="enteredCreditCardInfo.selectedYear" data-ng-options="year for year in creditYearList" client-validation="onExit" data-required-on-exit="" data-subsection="creditCard"><option value="" class="">Year</option><option value="0">2020</option><option value="1">2021</option><option value="2">2022</option><option value="3">2023</option><option value="4">2024</option><option value="5">2025</option><option value="6">2026</option><option value="7">2027</option><option value="8">2028</option><option value="9">2029</option><option value="10">2030</option></select><span class="missing">Please enter the expiration date.</span>
<span >The date you selected is in the past. Please try again.</span>
</fieldset>
<label data-ng-show="enteredCreditCardInfo.hasCCV">
Expand Down

0 comments on commit a1c66df

Please sign in to comment.