-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add tooltip to date/time control picker indicator element
Prior to this change, the picker indicator element (the "icon" that can be clicked on to open the popup) did not have a tooltip. With this CL, we add a tooltip where the tooltip text matches the indicator element's aria-label (e.g. "Show X picker"). Bug: 1473774 Change-Id: I4a156753cea4d44722e8636492c90bce7e94fd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767916 Commit-Queue: Stephanie Zhang <stephanie.zhang@microsoft.com> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1184963}
- Loading branch information
1 parent
3dd7521
commit a1d53f1
Showing
24 changed files
with
83 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 9 additions & 12 deletions
21
content/test/data/accessibility/html/input-month-expected-win.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,9 @@ | ||
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE | ||
++IA2_ROLE_SECTION READONLY | ||
++++IA2_ROLE_DATE_EDITOR FOCUSABLE | ||
++++++IA2_ROLE_SECTION | ||
++++++++IA2_ROLE_SECTION | ||
++++++++++ROLE_SYSTEM_SPINBUTTON name='Month' FOCUSABLE | ||
++++++++++ROLE_SYSTEM_STATICTEXT name=', ' | ||
++++++++++ROLE_SYSTEM_SPINBUTTON name='Year' FOCUSABLE | ||
++++++ROLE_SYSTEM_BUTTONMENU FOCUSABLE | ||
++++++ROLE_SYSTEM_SPINBUTTON | ||
++++++++ROLE_SYSTEM_PUSHBUTTON | ||
++++++++ROLE_SYSTEM_PUSHBUTTON | ||
ROLE_SYSTEM_DOCUMENT value='http://a.test:57795/accessibility/html/input-month.html' READONLY FOCUSABLE ia2_hypertext='<obj0>' | ||
++IA2_ROLE_SECTION ia2_hypertext='<obj0>' | ||
++++IA2_ROLE_DATE_EDITOR FOCUSABLE text-input-type:month ia2_hypertext='<obj0><obj1>' | ||
++++++IA2_ROLE_SECTION ia2_hypertext='<obj0>' | ||
++++++++IA2_ROLE_SECTION ia2_hypertext='<obj0> <obj2>' | ||
++++++++++ROLE_SYSTEM_SPINBUTTON name='Month' value='0' FOCUSABLE valuetext:0 | ||
++++++++++ROLE_SYSTEM_STATICTEXT name=' ' ia2_hypertext=' ' | ||
++++++++++ROLE_SYSTEM_SPINBUTTON name='Year' value='0' FOCUSABLE valuetext:0 | ||
++++++ROLE_SYSTEM_BUTTONMENU name='Show month picker' FOCUSABLE HASPOPUP description-from:tooltip haspopup:menu description='Show month picker' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters