Skip to content

Commit

Permalink
[iOS] Remove legacy sign-in view
Browse files Browse the repository at this point in the history
This CL remove all the code and resources used by the legacy sign-in
view as they are no longer used.

Bug: 1407658

Change-Id: Id0d38cb90a19b52b89189af9eeddd043d3222a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4184205
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1096167}
  • Loading branch information
Mihai Sardarescu authored and Chromium LUCI CQ committed Jan 24, 2023
1 parent 479fd44 commit a61c830
Show file tree
Hide file tree
Showing 30 changed files with 0 additions and 1,516 deletions.
3 changes: 0 additions & 3 deletions ios/chrome/app/strings/ios_chromium_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,6 @@ locale. The strings in this file are specific to iOS.
<message name="IDS_IOS_FIRST_RUN_SIGNIN_SUBTITLE_SHORT" desc="Subtitle of the screen suggesting to the user to sign in. [iOS only]">
Sign in to get the most out of Chromium.
</message>
<message name="IDS_IOS_FIRST_RUN_SIGNIN_SUBTITLE_MANAGED" desc="Subtitle of the screen suggesting to the user to sign in when their Sign In is managed by their administrator.">
Sign in to Chromium
</message>
<message name="IDS_IOS_FIRST_RUN_SIGNIN_SUBTITLE_SIGNIN_FORCED" desc="Subtitle of a dialog to sign in to Chrome when sign-in is required because of an enterprise policy. [iOS only]">
Your organization requires you to sign in to use Chromium.
</message>
Expand Down

This file was deleted.

3 changes: 0 additions & 3 deletions ios/chrome/app/strings/ios_google_chrome_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,6 @@ locale. The strings in this file are specific to iOS.
<message name="IDS_IOS_FIRST_RUN_SIGNIN_SUBTITLE_SHORT" desc="Subtitle of the screen suggesting to the user to sign in. [iOS only]">
Sign in to get the most out of Chrome.
</message>
<message name="IDS_IOS_FIRST_RUN_SIGNIN_SUBTITLE_MANAGED" desc="Subtitle of the screen suggesting to the user to sign in when their Sign In is managed by their administrator.">
Sign in to Chrome
</message>
<message name="IDS_IOS_FIRST_RUN_SIGNIN_SUBTITLE_SIGNIN_FORCED" desc="Subtitle of a dialog to sign in to Chrome when sign-in is required because of an enterprise policy. [iOS only]">
Your organization requires you to sign in to use Chrome.
</message>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ source_set("forced_signin") {
"//ios/chrome/browser/ui/authentication/signin:signin_protected",
"//ios/chrome/browser/ui/first_run:screen_delegate",
"//ios/chrome/browser/ui/first_run:utils",
"//ios/chrome/browser/ui/first_run/legacy_signin",
"//ios/chrome/browser/ui/first_run/signin",
"//ios/chrome/browser/ui/screen:screen_provider",
"//ios/chrome/browser/ui/screen:screen_type",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
#import "ios/chrome/browser/ui/authentication/signin/signin_coordinator+protected.h"
#import "ios/chrome/browser/ui/first_run/first_run_screen_delegate.h"
#import "ios/chrome/browser/ui/first_run/first_run_util.h"
#import "ios/chrome/browser/ui/first_run/legacy_signin/legacy_signin_screen_coordinator.h"
#import "ios/chrome/browser/ui/first_run/signin/signin_screen_coordinator.h"
#import "ios/chrome/browser/ui/screen/screen_provider.h"
#import "ios/chrome/browser/ui/screen/screen_type.h"
Expand Down Expand Up @@ -110,11 +109,6 @@ - (void)presentScreen:(ScreenType)type {
- (InterruptibleChromeCoordinator*)createChildCoordinatorWithScreenType:
(ScreenType)type {
switch (type) {
case kLegacySignIn_DEPRECATED:
return [[LegacySigninScreenCoordinator alloc]
initWithBaseNavigationController:self.navigationController
browser:self.browser
delegate:self];
case kSignIn:
return [[SigninScreenCoordinator alloc]
initWithBaseNavigationController:self.navigationController
Expand Down
1 change: 0 additions & 1 deletion ios/chrome/browser/ui/first_run/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ source_set("first_run") {
"//ios/chrome/browser/ui/elements:elements_internal",
"//ios/chrome/browser/ui/fancy_ui",
"//ios/chrome/browser/ui/first_run/default_browser",
"//ios/chrome/browser/ui/first_run/legacy_signin",
"//ios/chrome/browser/ui/first_run/signin",
"//ios/chrome/browser/ui/first_run/tangible_sync",
"//ios/chrome/browser/ui/first_run/welcome",
Expand Down
6 changes: 0 additions & 6 deletions ios/chrome/browser/ui/first_run/first_run_coordinator.mm
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#import "ios/chrome/browser/ui/first_run/default_browser/default_browser_screen_coordinator.h"
#import "ios/chrome/browser/ui/first_run/first_run_screen_delegate.h"
#import "ios/chrome/browser/ui/first_run/first_run_util.h"
#import "ios/chrome/browser/ui/first_run/legacy_signin/legacy_signin_screen_coordinator.h"
#import "ios/chrome/browser/ui/first_run/signin/signin_screen_coordinator.h"
#import "ios/chrome/browser/ui/first_run/tangible_sync/tangible_sync_screen_coordinator.h"
#import "ios/chrome/browser/ui/first_run/welcome/welcome_screen_coordinator.h"
Expand Down Expand Up @@ -150,11 +149,6 @@ - (ChromeCoordinator*)createChildCoordinatorWithScreenType:(ScreenType)type {
initWithBaseNavigationController:self.navigationController
browser:self.browser
delegate:self];
case kLegacySignIn_DEPRECATED:
return [[LegacySigninScreenCoordinator alloc]
initWithBaseNavigationController:self.navigationController
browser:self.browser
delegate:self];
case kDefaultBrowserPromo:
return [[DefaultBrowserScreenCoordinator alloc]
initWithBaseNavigationController:self.navigationController
Expand Down
92 changes: 0 additions & 92 deletions ios/chrome/browser/ui/first_run/legacy_signin/BUILD.gn

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit a61c830

Please sign in to comment.