[Metadata] Flag for new Card Art and Network Icons

This will flag-protect future changes for the larger images/icons, removing the grey overlay, and adding a white border. Bug: 1313616 Change-Id: I91eb2b580b14810054a0486b5abe700f13c28c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4277704 Commit-Queue: Alexander Tekle <alexandertekle@google.com> Reviewed-by: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/main@{#1108095}
chromium · Feb 22, 2023 · a82c414 · a82c414
1 parent b9a82cf
commit a82c414
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 0 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -9405,6 +9405,13 @@ const FeatureEntry kFeatureEntries[] = {
          autofill::features::kAutofillEnableNewSaveCardBubbleUi)},
 #endif  // !BUILDFLAG(IS_ANDROID)
 
+    {"autofill-enable-new-card-art-and-network-images",
+     flag_descriptions::kAutofillEnableNewCardArtAndNetworkImagesName,
+     flag_descriptions::kAutofillEnableNewCardArtAndNetworkImagesDescription,
+     kOsAll,
+     FEATURE_VALUE_TYPE(
+         autofill::features::kAutofillEnableNewCardArtAndNetworkImages)},
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -484,6 +484,11 @@
     "owners": [ "siashah", "siyua" ],
     "expiry_milestone": 116
   },
+  {
+    "name": "autofill-enable-new-card-art-and-network-images",
+    "owners": ["alexandertekle@google.com", "vishwasuppoor@google.com"],
+    "expiry_milestone": 122
+  },
   {
       "name": "autofill-enable-new-card-unmask-prompt-view",
       "owners": [ "eic", "bling-flags@google.com" ],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -394,6 +394,11 @@ const char kAutofillEnableCvcForVcnYellowPathDescription[] =
     "for CVC authentication, CVC authentication will be offered as one of the "
     "challenge options.";
 
+const char kAutofillEnableNewCardArtAndNetworkImagesName[] =
+    "Enable showing new card art and network images";
+const char kAutofillEnableNewCardArtAndNetworkImagesDescription[] =
+    "When enabled, new and larger card art and network icons will be shown.";
+
 const char kAutofillEnableOfferNotificationForPromoCodesName[] =
     "Extend Autofill offers and rewards notification to promo code offers";
 const char kAutofillEnableOfferNotificationForPromoCodesDescription[] =

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -225,6 +225,9 @@ extern const char kAutofillEnableCardProductNameDescription[];
 extern const char kAutofillEnableCvcForVcnYellowPathName[];
 extern const char kAutofillEnableCvcForVcnYellowPathDescription[];
 
+extern const char kAutofillEnableNewCardArtAndNetworkImagesName[];
+extern const char kAutofillEnableNewCardArtAndNetworkImagesDescription[];
+
 extern const char kAutofillEnableOfferNotificationForPromoCodesName[];
 extern const char kAutofillEnableOfferNotificationForPromoCodesDescription[];
 

diff --git a/components/autofill/core/common/autofill_payments_features.cc b/components/autofill/core/common/autofill_payments_features.cc
@@ -67,6 +67,13 @@ BASE_FEATURE(kAutofillEnableCvcForVcnYellowPath,
              "AutofillEnableCvcForVcnYellowPath",
              base::FEATURE_ENABLED_BY_DEFAULT);
 
+// When enabled, user's will see network card art images and network icons which
+// are larger, having a white border, and don't have the standard grey overlay
+// applied to them.
+BASE_FEATURE(kAutofillEnableNewCardArtAndNetworkImages,
+             "AutofillEnableNewCardArtAndNetworkImages",
+             base::FEATURE_DISABLED_BY_DEFAULT);
+
 // When enabled, a progress dialog will display while authenticating with FIDO.
 // TODO(crbug.com/1337380): Clean up kAutofillEnableFIDOProgressDialog when it's
 // fully rolled out.

diff --git a/components/autofill/core/common/autofill_payments_features.h b/components/autofill/core/common/autofill_payments_features.h
@@ -21,6 +21,7 @@ BASE_DECLARE_FEATURE(kAutofillEnableCardProductName);
 BASE_DECLARE_FEATURE(kAutofillEnableCvcForVcnYellowPath);
 BASE_DECLARE_FEATURE(kAutofillEnableFIDOProgressDialog);
 BASE_DECLARE_FEATURE(kAutofillEnableManualFallbackForVirtualCards);
+BASE_DECLARE_FEATURE(kAutofillEnableNewCardArtAndNetworkImages);
 BASE_DECLARE_FEATURE(kAutofillEnableNewSaveCardBubbleUi);
 BASE_DECLARE_FEATURE(kAutofillEnableOfferNotificationForPromoCodes);
 BASE_DECLARE_FEATURE(kAutofillEnableOffersInClankKeyboardAccessory);

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -62321,6 +62321,8 @@ from previous Chrome versions.
       label="enable-ambient-authentication-in-guest-session"/>
   <int value="308972768" label="AccessibilityFormControlsAXMode:enabled"/>
   <int value="309795366" label="ScrollUnification:disabled"/>
+  <int value="309861115"
+      label="AutofillEnableNewCardArtAndNetworkImages:enabled"/>
   <int value="310143091"
       label="AutofillImportNonFocusableCreditCardForms:enabled"/>
   <int value="310183389" label="AutofillFillIbanFields:enabled"/>
@@ -64718,6 +64720,8 @@ from previous Chrome versions.
   <int value="1692847616" label="ArcEnableWebAppShare:enabled"/>
   <int value="1693094211" label="FilesNG:disabled"/>
   <int value="1693658048" label="AppsShortcutDefaultOff:enabled"/>
+  <int value="1693685694"
+      label="AutofillEnableNewCardArtAndNetworkImages:disabled"/>
   <int value="1694663094" label="RobustAudioDeviceSelectLogic:disabled"/>
   <int value="1694766748"
       label="AutofillRestrictUnownedFieldsToFormlessCheckout:enabled"/>