Skip to content

Commit

Permalink
Removed unnecessary spacing for links in Settings
Browse files Browse the repository at this point in the history
Extra margin spacing is unnecessarily added to links on the settings
page. Removed the extra margin spacing CSS rule and instances where
older code worked around the margin spacing by resetting the CSS.

Manually tested the settings page and saw no noticeable issues with
removing the extra margins.

Before Bug Fix: https://screenshot.googleplex.com/Bngfht682PF5fpx.png
After Bug Fix: https://screenshot.googleplex.com/5Ba4jVtjSxpdsbG.png

Fixed: 1396369
Change-Id: I9f1017f822dec63c3cbf2f7cc5164e4aa51d1e00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114464
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Steven Luong <stluong@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1085044}
  • Loading branch information
Steven Luong authored and Chromium LUCI CQ committed Dec 19, 2022
1 parent 6300fe6 commit ac13ecf
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 18 deletions.
@@ -1,8 +1,4 @@
<style include="settings-shared">
:host {
--cr-subsequent-anchors-of-span-margin: 0;
}
</style>
<style include="settings-shared"></style>
<div id="container"
inner-h-t-m-l="[[getAriaLabelledContent_()]]">
</div>
Expand Up @@ -10,10 +10,6 @@
outline: none;
}

.peripheral-data-access-protection {
/* Remove the unecessary spacing infront of the learn-more link. */
--cr-subsequent-anchors-of-span-margin: 0;
}
</style>
<os-settings-animated-pages id="pages" section="osPrivacy"
focus-config="[[focusConfig_]]">
Expand Down
Expand Up @@ -9,10 +9,6 @@
padding-inline-start: 0;
}

#quick-answers-enable {
--cr-subsequent-anchors-of-span-margin: 0;
}

#quick-answers-definition-enable {
border-top: none;
}
Expand Down
4 changes: 0 additions & 4 deletions chrome/browser/resources/settings/settings_shared.css
Expand Up @@ -78,10 +78,6 @@ iron-list[risk-selection] {
margin-inline-start: 8px;
}

span ~ a {
margin-inline-start: var(--cr-subsequent-anchors-of-span-margin, 4px);
}

a[href] {
color: var(--cr-link-color);
}
Expand Down
@@ -1,7 +1,6 @@
<style include="cr-shared-style">
:host {
--cr-localized-link-display: inline;
--cr-subsequent-anchors-of-span-margin: 0;
}

a {
Expand Down

0 comments on commit ac13ecf

Please sign in to comment.