Set Origin-Agent-Cluster header for 3 tests.

The WebPagePopupImpl constructor has special handling for origin agent clusters to support testing, that these particular tests rely on. This mechanism will break if Origin-Agent-Clustersare enabled by default. Hence we opt-out of OAC by setting the appropriate header on these tests (and their support resources). This will keep the tests functional. Bug: 1259920 Change-Id: I4ae3a90acdad57a5b7ec632bfd674c8be966d61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4110839 Reviewed-by: Nate Chapin <japhet@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/main@{#1084724}
chromium · Dec 17, 2022 · ad4c21c · ad4c21c
1 parent 91db9fa
commit ad4c21c
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 3 deletions.
diff --git a/third_party/blink/web_tests/SlowTests b/third_party/blink/web_tests/SlowTests
@@ -564,7 +564,7 @@ crbug.com/1093849 external/wpt/dom/nodes/Element-classlist.html [ Slow ]
 crbug.com/1093853 external/wpt/dom/ranges/Range-surroundContents.html [ Slow ]
 crbug.com/1093478 external/wpt/quirks/unitless-length/limited-quirks.html [ Slow ]
 crbug.com/1133836 external/wpt/scroll-to-text-fragment/redirects.html [ Slow ]
-crbug.com/1134580 http/tests/eye-dropper/color-picker-show-eye-dropper.html [ Slow ]
+crbug.com/1134580 http/tests/eye-dropper/color-picker-show-eye-dropper.php [ Slow ]
 crbug.com/1145716 fast/forms/calendar-picker/datetimelocal-picker-open-to-focused-field.html [ Slow ]
 
 # These began to hit timeouts when moving from Windows-10-15063 to Windows-10-18363

diff --git a/...ropper/color-picker-show-eye-dropper.html → ...dropper/color-picker-show-eye-dropper.php b/...ropper/color-picker-show-eye-dropper.html → ...dropper/color-picker-show-eye-dropper.php
@@ -1,3 +1,6 @@
+<?php
+header("Origin-Agent-Cluster: ?0");
+?>
 <!DOCTYPE html>
 <html>
 <head>

diff --git a/...s/color-picker-keyboard-cross-domain.html → ...ms/color-picker-keyboard-cross-domain.php b/...s/color-picker-keyboard-cross-domain.html → ...ms/color-picker-keyboard-cross-domain.php
@@ -1,3 +1,6 @@
+<?php
+header("Origin-Agent-Cluster: ?0");
+?>
 <!DOCTYPE html>
 <html>
 <head>
@@ -9,7 +12,7 @@
     let t = async_test("Test input color popup's keyboard usability when inside cross-process iframe.");
 
     let iframe = document.createElement("iframe");
-    iframe.src = "http://localhost:8000/forms/resources/color-picker-keyboard-cross-domain-iframe.html";
+    iframe.src = "http://localhost:8000/forms/resources/color-picker-keyboard-cross-domain-iframe.php";
 
     const runTest = t.step_func((event) => {
       // The eventSender.keyDown() invocations in the iframe create extra window messages.

diff --git a/...ms/date-picker-keyboard-cross-domain.html → ...rms/date-picker-keyboard-cross-domain.php b/...ms/date-picker-keyboard-cross-domain.html → ...rms/date-picker-keyboard-cross-domain.php
@@ -1,3 +1,6 @@
+<?php
+header("Origin-Agent-Cluster: ?0");
+?>
 <!DOCTYPE html>
 <html>
 <head>
@@ -9,7 +12,7 @@
     let t = async_test("Test input date popup's keyboard usability when inside cross-process iframe.");
 
     let iframe = document.createElement("iframe");
-    iframe.src = "http://localhost:8000/forms/resources/date-picker-keyboard-cross-domain-iframe.html";
+    iframe.src = "http://localhost:8000/forms/resources/date-picker-keyboard-cross-domain-iframe.php";
 
     const runTest = t.step_func((event) => {
       // The eventSender.keyDown() invocations in the iframe create extra window messages.

diff --git a/...-picker-keyboard-cross-domain-iframe.html → ...r-picker-keyboard-cross-domain-iframe.php b/...-picker-keyboard-cross-domain-iframe.html → ...r-picker-keyboard-cross-domain-iframe.php
@@ -1,3 +1,6 @@
+<?php
+header("Origin-Agent-Cluster: ?0");
+?>
 <html>
   <input type="color" id="color" value="#126465">
 

diff --git a/...-picker-keyboard-cross-domain-iframe.html → ...e-picker-keyboard-cross-domain-iframe.php b/...-picker-keyboard-cross-domain-iframe.html → ...e-picker-keyboard-cross-domain-iframe.php
@@ -1,3 +1,6 @@
+<?php
+header("Origin-Agent-Cluster: ?0");
+?>
 <html>
   <input type="date" id="date" value="2019-12-12">