Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Tighten fuzzy parameters in form_controls_browsertest.cc"
This reverts commit 3fc2887. Reason for revert: Original change touches FormControlsBrowserTest.*, which is failing on many Mac and Fuchsia builders: * https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-arm64-cast-receiver-rel/3107/overview * https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-x64-cast-receiver-rel/2977/overview * https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.14%20Tests/31023/overview * https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.13%20Tests/61108/overview * https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-x64-rel/3114/overview * https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-arm64-rel/3529/overview Original change's description: > Tighten fuzzy parameters in form_controls_browsertest.cc > > This is a followup of crrev.com/c/4184656 and crrev.com/c/4185898. > > Now form_controls_browsertest.cc tolerates fewer large error pixels > and more small error pixels. The tolerances are updated based on > try results, with baselines regenerated. > > form_controls_browsertest.cc is moved from content/browser to > content/renderer because it tests renderer functionality. Also move > function MacOSVersionSupportsDarkMode() into browser_test_utils.h and > use it from both form_controls_browsertest.cc and > focus_ring_browsertest.cc. > > Cq-Include-Trybots: luci.chromium.try:mac10.13-blink-rel,mac10.14-blink-rel,mac10.15-blink-rel > Change-Id: I3ad18958917ea0280a18d842b8784a26faa497d3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4183008 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1098071} Change-Id: Ia51f91c4726a78d2211d6aec32e6ce3c3498ac70 Cq-Include-Trybots: luci.chromium.try:mac10.13-blink-rel,mac10.14-blink-rel,mac10.15-blink-rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198496 Commit-Queue: Jonathan Lee <jonathanjlee@google.com> Auto-Submit: Jonathan Lee <jonathanjlee@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Jonathan Lee <jonathanjlee@google.com> Cr-Commit-Position: refs/heads/main@{#1098143}
- Loading branch information
1 parent
17f56fc
commit ada2293
Showing
43 changed files
with
81 additions
and
60 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Copyright 2020 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#ifndef CHROME_BROWSER_FOCUS_RING_BROWSERTEST_MAC_H_ | ||
#define CHROME_BROWSER_FOCUS_RING_BROWSERTEST_MAC_H_ | ||
|
||
bool MacOSVersionSupportsDarkMode(); | ||
|
||
#endif // CHROME_BROWSER_FOCUS_RING_BROWSERTEST_MAC_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Copyright 2020 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#include "chrome/browser/focus_ring_browsertest_mac.h" | ||
|
||
bool MacOSVersionSupportsDarkMode() { | ||
if (@available(macOS 10.14, *)) | ||
return true; | ||
return false; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// Copyright 2021 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#ifndef CONTENT_BROWSER_FORM_CONTROLS_BROWSERTEST_MAC_H_ | ||
#define CONTENT_BROWSER_FORM_CONTROLS_BROWSERTEST_MAC_H_ | ||
|
||
bool MacOSVersionSupportsDarkMode(); | ||
|
||
#endif // CONTENT_BROWSER_FORM_CONTROLS_BROWSERTEST_MAC_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Copyright 2021 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#include "content/browser/form_controls_browsertest_mac.h" | ||
|
||
bool MacOSVersionSupportsDarkMode() { | ||
if (@available(macOS 10.14, *)) | ||
return true; | ||
return false; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+4 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_button_android.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+11 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_button_linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-106 Bytes
(99%)
content/test/data/forms/form_controls_browsertest_button_win.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-871 Bytes
content/test/data/forms/form_controls_browsertest_checkbox_mac.png
Binary file not shown.
Binary file modified
BIN
+58 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_color_input_mac.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+0 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_color_input_win.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
...nt/test/data/forms/form_controls_browsertest_dark_mode_text_selection_linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-53 Bytes
(99%)
content/test/data/forms/form_controls_browsertest_dark_mode_text_selection_mac.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-10 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_input_android.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-10 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_input_linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-198 Bytes
(92%)
content/test/data/forms/form_controls_browsertest_input_mac.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-173 Bytes
(93%)
content/test/data/forms/form_controls_browsertest_input_win.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+39 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_meter_android.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+23 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_meter_linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_meter_mac.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-49 Bytes
(98%)
content/test/data/forms/form_controls_browsertest_meter_win.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-38 Bytes
(99%)
content/test/data/forms/form_controls_browsertest_multi_select_android.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1 Byte
(100%)
content/test/data/forms/form_controls_browsertest_multi_select_linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_multi_select_mac.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-28 Bytes
(99%)
content/test/data/forms/form_controls_browsertest_multi_select_win.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_progress_linux.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+101 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_progress_mac.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+100 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_progress_win.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+237 Bytes
(120%)
content/test/data/forms/form_controls_browsertest_radio_android.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_range_linux.png
Oops, something went wrong.
Binary file modified
BIN
+17 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_range_mac.png
Oops, something went wrong.
Binary file modified
BIN
+943 Bytes
(140%)
content/test/data/forms/form_controls_browsertest_select_android.png
Oops, something went wrong.
Binary file modified
BIN
+963 Bytes
(140%)
content/test/data/forms/form_controls_browsertest_select_linux.png
Oops, something went wrong.
Binary file modified
BIN
+3 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_select_win.png
Oops, something went wrong.
Binary file modified
BIN
-11 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_textarea_android.png
Oops, something went wrong.
Binary file modified
BIN
+19 Bytes
(100%)
content/test/data/forms/form_controls_browsertest_textarea_linux.png
Oops, something went wrong.
Binary file modified
BIN
-31 Bytes
(99%)
content/test/data/forms/form_controls_browsertest_textarea_win.png
Oops, something went wrong.