Skip to content

Commit

Permalink
Add virtual suite with recent dir and lang changes disabled.
Browse files Browse the repository at this point in the history
I filtered out all but one of the relevant reftests that pass only with
the changes, but I was a bit more generous with the script tests since
we check the error messages, and in some cases parts of the failing
tests, or which error message we get, is testing something useful.

A content_shell built from 0e979ba
produces results that match these expectations (which shows that recent
changes didn't break the disabled state).

Bug: 576815, 1490711
Change-Id: I144842c669e8184cb560fae9e094bcdc612e333e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4982141
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Auto-Submit: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1216389}
  • Loading branch information
dbaron authored and Chromium LUCI CQ committed Oct 27, 2023
1 parent 1702abd commit af2d70f
Show file tree
Hide file tree
Showing 12 changed files with 314 additions and 0 deletions.
3 changes: 3 additions & 0 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -4357,6 +4357,9 @@ crbug.com/1469418 virtual/details-styling-disabled/external/wpt/html/rendering/t
crbug.com/1469418 virtual/details-styling-disabled/external/wpt/html/rendering/the-details-element/details-pseudo-elements-001.tentative.html [ Failure ]
crbug.com/1469418 virtual/details-styling-disabled/external/wpt/html/rendering/the-details-element/details-pseudo-elements-002.tentative.html [ Failure ]

# reftests that only pass when the new direction code is enabled.
crbug.com/576815 virtual/dir-pseudo-disabled/external/wpt/html/dom/elements/global-attributes/dir_auto-N-EN.html [ Failure ]

# SwANGLE issues
crbug.com/1204234 css3/blending/background-blend-mode-single-accelerated-element.html [ Failure ]

Expand Down
84 changes: 84 additions & 0 deletions third_party/blink/web_tests/VirtualTestSuites
Original file line number Diff line number Diff line change
Expand Up @@ -1164,6 +1164,90 @@
"--disable-threaded-compositing", "--disable-threaded-animation"],
"expires": "Apr 1, 2024"
},
{
"prefix": "dir-pseudo-disabled",
"owners": ["dbaron@chromium.org", "dom-dev@chromium.org"],
"platforms": ["Linux"],
"bases": [
"external/wpt/css/selectors/dir-pseudo-on-bdi-element.html",
"external/wpt/css/selectors/dir-pseudo-on-input-element.html",
"external/wpt/css/selectors/dir-selector-auto.html",
"external/wpt/css/selectors/dir-selector-querySelector.html",
"external/wpt/html/dom/elements/global-attributes/dir-assorted.window.js",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-bdi-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-bdi-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-dir-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-dir-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-script-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-script-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-style-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-style-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-textarea-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-contained-textarea-R.html",
"external/wpt/html/dom/elements/global-attributes/dir-auto-div-append-child.html",
"external/wpt/html/dom/elements/global-attributes/dir-auto-dynamic-changes.window.js",
"external/wpt/html/dom/elements/global-attributes/dir_auto-EN-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-EN-R.html",
"external/wpt/html/dom/elements/global-attributes/dir-auto-form-associated.window.js",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-EN-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-EN-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-N-EN.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-N-EN-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-N-EN-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-N-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-N-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-EN-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-EN-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-N-EN.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-N-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-N-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-input-script-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-isolate.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-N-EN.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-N-EN-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-N-EN-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-N-L.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-N-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-pre-mixed.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-pre-N-between-Rs.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-pre-N-EN.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-R.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-textarea-mixed.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-textarea-N-EN.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-textarea-script-mixed.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs.html",
"external/wpt/html/dom/elements/global-attributes/dir_auto-textarea-script-N-EN.html",
"external/wpt/html/dom/elements/global-attributes/dir-bdi-script.html",
"external/wpt/html/dom/elements/global-attributes/dir-slots-directionality.html",
"external/wpt/html/dom/elements/global-attributes/document-dir.html",
"external/wpt/html/dom/elements/global-attributes/lang-attribute-shadow.window.js",
"external/wpt/html/dom/elements/global-attributes/lang-attribute.window.js",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-002.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-003.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-004.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-005.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-006.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-007.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-008.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-009.html",
"external/wpt/html/dom/elements/global-attributes/the-lang-attribute-010.html"
],
"args": ["--disable-blink-features=CSSPseudoDir",
"--disable-blink-features=HTMLLangNewInheritance",
"--disable-threaded-compositing", "--disable-threaded-animation"],
"expires": "Feb 1, 2024"
},
{
"prefix": "backface-visibility-interop",
"owners": ["dbaron@chromium.org", "paint-dev@chromium.org"],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
This suite runs tests with --disable-blink-features=CSSPseudoDir and
--disable-blink-features=HTMLLangNewInheritance

This is intended to make sure we don't change the relevant tests in case
we need to revert these feature flags.
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
This is a testharness.js-based test.
[FAIL] bdi element without dir content attribute
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] bdi element with invalid dir content attribute
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] bdi element with dir=auto content attribute
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] bdi element with dir=ltr content attribute
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] bdi element with dir=rtl content attribute
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
Harness: the test ran to completion.

Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
This is a testharness.js-based test.
[FAIL] input element whose type attribute is in the telephone state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the telephone state in a RTL block
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the password state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the text state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the search state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the url state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the email state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the submit state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the reset state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the button state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] dynamic changes to type of input elements affect whether value is used for dir=auto
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the date state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the time state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the number state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the range state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the color state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the checkbox state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the radio state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] input element whose type attribute is in the image state
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
Harness: the test ran to completion.

Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
This is a testharness.js-based test.
[FAIL] Initial directionality of element div1 is ltr
Failed to execute 'querySelector' on 'Document': '#div1:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div1_1 is ltr
Failed to execute 'querySelector' on 'Document': '#div1_1:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div2 is rtl
Failed to execute 'querySelector' on 'Document': '#div2:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div2_1 is rtl
Failed to execute 'querySelector' on 'Document': '#div2_1:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div3 is ltr
Failed to execute 'querySelector' on 'Document': '#div3:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div3_1 is rtl
Failed to execute 'querySelector' on 'Document': '#div3_1:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div3_2 is ltr
Failed to execute 'querySelector' on 'Document': '#div3_2:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div4 is ltr
Failed to execute 'querySelector' on 'Document': '#div4:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div4_1 is ltr
Failed to execute 'querySelector' on 'Document': '#div4_1:dir(ltr)' is not a valid selector.
[FAIL] Initial directionality of element div4_1_1 is ltr
Failed to execute 'querySelector' on 'Document': '#div4_1_1:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div1 is rtl
Failed to execute 'querySelector' on 'Document': '#div1:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div1_1 is rtl
Failed to execute 'querySelector' on 'Document': '#div1_1:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div1 is ltr
Failed to execute 'querySelector' on 'Document': '#div1:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div1_1 is ltr
Failed to execute 'querySelector' on 'Document': '#div1_1:dir(ltr)' is not a valid selector.
[FAIL] Reupdated directionality of element div1 is ltr
Failed to execute 'querySelector' on 'Document': '#div1:dir(ltr)' is not a valid selector.
[FAIL] Reupdated directionality of element div1_1 is ltr
Failed to execute 'querySelector' on 'Document': '#div1_1:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div2 is ltr
Failed to execute 'querySelector' on 'Document': '#div2:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div3 is rtl
Failed to execute 'querySelector' on 'Document': '#div3:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div3 is ltr
Failed to execute 'querySelector' on 'Document': '#div3:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div4 is rtl
Failed to execute 'querySelector' on 'Document': '#div4:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div4_1 is rtl
Failed to execute 'querySelector' on 'Document': '#div4_1:dir(ltr)' is not a valid selector.
[FAIL] Updated directionality of element div4_1_1 is rtl
Failed to execute 'querySelector' on 'Document': '#div4_1_1:dir(ltr)' is not a valid selector.
Harness: the test ran to completion.

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
This is a testharness.js-based test.
[FAIL] :dir() allows any ident value but strings other than ltr/rtl don't match
Failed to execute 'querySelector' on 'Document': ':dir(lol)' is not a valid selector.
[PASS] :dir() requires exactly an ident argument
[FAIL] :dir() works in compound selectors
Failed to execute 'querySelector' on 'Document': ':dir(rtl)' is not a valid selector.
[FAIL] :dir() works in complex selectors
Failed to execute 'querySelector' on 'Document': '#div2 :dir(ltr)' is not a valid selector.
Harness: the test ran to completion.

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
This is a testharness.js-based test.
[FAIL] Root element has a direction
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] Element outside the document tree has a direction
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] Non-HTML element outside the document tree has a direction
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] Element without direction has parent element direction
Failed to execute 'matches' on 'Element': ':dir(rtl)' is not a valid selector.
[FAIL] Non-HTML element without direction has parent element direction
Failed to execute 'matches' on 'Element': ':dir(rtl)' is not a valid selector.
[FAIL] dir inheritance is correct after insertion and removal from document
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] Non-HTML element text contents influence dir=auto
Failed to execute 'matches' on 'Element': ':dir(rtl)' is not a valid selector.
[FAIL] text changes apply to dir=auto on further ancestor after removing dir=auto from closer ancestor
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
Harness: the test ran to completion.

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
This is a testharness.js-based test.
[FAIL] dynamic insertion of RTL text in a child element
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] dir=auto changes for content insertion and removal, in and out of document
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] dir=auto changes for slot reassignment
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] text changes affecting both slot and ancestor with dir=auto
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] dynamic changes to subtrees excluded as a result of the dir attribute
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] dynamic changes inside of non-HTML elements
Failed to execute 'matches' on 'Element': ':dir(rtl)' is not a valid selector.
[FAIL] slotted non-HTML elements
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
[FAIL] slotted non-HTML elements after dynamically assigning dir=auto, and dir attribute ignored on non-HTML elements
Failed to execute 'matches' on 'Element': ':dir(ltr)' is not a valid selector.
Harness: the test ran to completion.

0 comments on commit af2d70f

Please sign in to comment.