Skip to content

Commit

Permalink
Remove OfflineIndicator feature flag
Browse files Browse the repository at this point in the history
Also remove dead controller code associated.

BUG=1385901

Change-Id: I795506ddabf697037b88cc927b3996556759615a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114155
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/main@{#1085125}
  • Loading branch information
ssiddhartha authored and Chromium LUCI CQ committed Dec 19, 2022
1 parent 6dd7929 commit b28e188
Show file tree
Hide file tree
Showing 16 changed files with 0 additions and 1,042 deletions.
1 change: 0 additions & 1 deletion chrome/android/chrome_java_resources.gni
Expand Up @@ -399,7 +399,6 @@ chrome_java_resources = [
"java/res/drawable/ic_new_tab_button.xml",
"java/res/drawable/ic_new_window.xml",
"java/res/drawable/ic_offer_tag.xml",
"java/res/drawable/ic_offline_pin_white.xml",
"java/res/drawable/ic_open_in_browser.xml",
"java/res/drawable/ic_person_add_40dp.xml",
"java/res/drawable/ic_reading_list_folder_24dp.xml",
Expand Down
3 changes: 0 additions & 3 deletions chrome/android/chrome_java_sources.gni
Expand Up @@ -832,12 +832,9 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/offlinepages/TriggerConditions.java",
"java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java",
"java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineDetector.java",
"java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorController.java",
"java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerV2.java",
"java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorInProductHelpController.java",
"java/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorMetricsDelegate.java",
"java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarManager.java",
"java/src/org/chromium/chrome/browser/offlinepages/indicator/TopSnackbarView.java",
"java/src/org/chromium/chrome/browser/offlinepages/measurements/OfflineMeasurementsBackgroundTask.java",
"java/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTask.java",
"java/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskScheduler.java",
Expand Down
1 change: 0 additions & 1 deletion chrome/android/chrome_test_java_sources.gni
Expand Up @@ -274,7 +274,6 @@ chrome_test_java_sources = [
"javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java",
"javatests/src/org/chromium/chrome/browser/offlinepages/RecentTabsTest.java",
"javatests/src/org/chromium/chrome/browser/offlinepages/RequestCoordinatorBridgeTest.java",
"javatests/src/org/chromium/chrome/browser/offlinepages/indicator/OfflineIndicatorControllerTest.java",
"javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchBackgroundTaskTest.java",
"javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchConfigurationTest.java",
"javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/TestOfflinePageService.java",
Expand Down
23 changes: 0 additions & 23 deletions chrome/android/java/res/drawable/ic_offline_pin_white.xml

This file was deleted.

Expand Up @@ -138,7 +138,6 @@
import org.chromium.chrome.browser.night_mode.WebContentsDarkModeMessageController;
import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.chrome.browser.offlinepages.indicator.OfflineIndicatorController;
import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;
import org.chromium.chrome.browser.page_info.ChromePageInfo;
import org.chromium.chrome.browser.page_info.ChromePageInfoHighlight;
Expand Down Expand Up @@ -979,7 +978,6 @@ public void onStartWithNative() {
super.onStartWithNative();
ChromeActivitySessionTracker.getInstance().onStartWithNative();
ChromeCachedFlags.getInstance().cacheNativeFlags();
OfflineIndicatorController.initialize();

// postDeferredStartupIfNeeded() is called in TabModelSelectorTabObsever#onLoadStopped(),
// #onPageLoadFinished() and #onCrash(). If we are not actively loading a tab (e.g.
Expand Down

This file was deleted.

0 comments on commit b28e188

Please sign in to comment.