-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CrOS Settings: Convert borealis and plugin vm detail views to TS
Additionally loads HTML templates for custom elements at runtime. Bug: chromium:1315757, chromium:1292025 Test: browser_tests --gtest_filter="OSSettingsAppManagement*" Change-Id: Ifdb2a65f17501ebc1bd162c700acc55b979f198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035910 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Wes Okuhara <wesokuhara@google.com> Cr-Commit-Position: refs/heads/main@{#1073640}
- Loading branch information
Wes Okuhara
authored and
Chromium LUCI CQ
committed
Nov 18, 2022
1 parent
0b751a9
commit b44e01f
Showing
10 changed files
with
92 additions
and
182 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 0 additions & 27 deletions
27
...owser/resources/settings/chromeos/os_apps_page/app_management_page/borealis_page/BUILD.gn
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 0 additions & 40 deletions
40
...wser/resources/settings/chromeos/os_apps_page/app_management_page/plugin_vm_page/BUILD.gn
This file was deleted.
Oops, something went wrong.
49 changes: 0 additions & 49 deletions
49
...tings/chromeos/os_apps_page/app_management_page/plugin_vm_page/plugin_vm_browser_proxy.js
This file was deleted.
Oops, something went wrong.
35 changes: 35 additions & 0 deletions
35
...tings/chromeos/os_apps_page/app_management_page/plugin_vm_page/plugin_vm_browser_proxy.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
// Copyright 2019 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
/** | ||
* @fileoverview A helper object used by the Plugin VM section | ||
* to manage the Plugin VM. | ||
*/ | ||
|
||
import {sendWithPromise} from 'chrome://resources/js/cr.m.js'; | ||
|
||
export interface PluginVmBrowserProxy { | ||
isRelaunchNeededForNewPermissions(): Promise<boolean>; | ||
relaunchPluginVm(): void; | ||
} | ||
|
||
let instance: PluginVmBrowserProxy|null = null; | ||
|
||
export class PluginVmBrowserProxyImpl implements PluginVmBrowserProxy { | ||
static getInstance(): PluginVmBrowserProxy { | ||
return instance || (instance = new PluginVmBrowserProxyImpl()); | ||
} | ||
|
||
static setInstanceForTesting(obj: PluginVmBrowserProxy): void { | ||
instance = obj; | ||
} | ||
|
||
isRelaunchNeededForNewPermissions(): Promise<boolean> { | ||
return sendWithPromise('isRelaunchNeededForNewPermissions'); | ||
} | ||
|
||
relaunchPluginVm(): void { | ||
chrome.send('relaunchPluginVm'); | ||
} | ||
} |
Oops, something went wrong.