Skip to content

Commit

Permalink
[CryptAuth] Remove device re-enroller
Browse files Browse the repository at this point in the history
Remove the device re-enroller used by v1 DeviceSync. It compared the
locally supported features with the list of supported features enrolled
with CryptAuth. If the features did not match, the device was
re-enrolled.

This re-enrollment functionality was implemented using v2 DeviceSync in
https://crrev.com/c/2300879. Because v2 DeviceSync is fully launched, we
have no need for the device re-enroller. Also, the device re-enroller is
causing crashes when v1 DeviceSync is disabled:
https://crbug.com/1195486.

(cherry picked from commit 4042f1e)

Fixed: 1195486
Change-Id: Ib755d54f12d34c5893c9fc37f661d9d8a45bb61b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2819218
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#871140}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2822070
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4472@{#36}
Cr-Branched-From: 3d60439-refs/heads/master@{#870763}
  • Loading branch information
nohle authored and Chromium LUCI CQ committed Apr 13, 2021
1 parent f8ba351 commit b4a805c
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 843 deletions.
3 changes: 0 additions & 3 deletions chromeos/services/multidevice_setup/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ static_library("multidevice_setup") {
"account_status_change_delegate_notifier_impl.h",
"android_sms_app_installing_status_observer.cc",
"android_sms_app_installing_status_observer.h",
"device_reenroller.cc",
"device_reenroller.h",
"device_with_connectivity_status.cc",
"device_with_connectivity_status.h",
"eligible_host_devices_provider.h",
Expand Down Expand Up @@ -134,7 +132,6 @@ source_set("unit_tests") {
sources = [
"account_status_change_delegate_notifier_impl_unittest.cc",
"android_sms_app_installing_status_observer_unittest.cc",
"device_reenroller_unittest.cc",
"eligible_host_devices_provider_impl_unittest.cc",
"feature_state_manager_impl_unittest.cc",
"grandfathered_easy_unlock_host_disabler_unittest.cc",
Expand Down
192 changes: 0 additions & 192 deletions chromeos/services/multidevice_setup/device_reenroller.cc

This file was deleted.

106 changes: 0 additions & 106 deletions chromeos/services/multidevice_setup/device_reenroller.h

This file was deleted.

0 comments on commit b4a805c

Please sign in to comment.