Skip to content

Commit

Permalink
[WebOTP] Clean up expired flags for cross-device support
Browse files Browse the repository at this point in the history
Bug: None
Change-Id: Iecf7492e56ae7469a56fd157761777a1656429ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3563586
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988202}
  • Loading branch information
yi-gu authored and Chromium LUCI CQ committed Apr 2, 2022
1 parent a392dd6 commit b5ed51d
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 16 deletions.
4 changes: 0 additions & 4 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
#include "chrome/browser/share/share_features.h"
#include "chrome/browser/sharing/features.h"
#include "chrome/browser/sharing/shared_clipboard/feature_flags.h"
#include "chrome/browser/sharing/sms/sms_flags.h"
#include "chrome/browser/sharing_hub/sharing_hub_features.h"
#include "chrome/browser/site_isolation/about_flags.h"
#include "chrome/browser/ui/app_list/search/search_features.h"
Expand Down Expand Up @@ -3143,9 +3142,6 @@ const FeatureEntry kFeatureEntries[] = {
kOsLinux | kOsCrOS | kOsWin | kOsAndroid | kOsFuchsia,
ENABLE_DISABLE_VALUE_TYPE(switches::kEnableSmoothScrolling,
switches::kDisableSmoothScrolling)},
{"sms-receiver-cross-device", flag_descriptions::kWebOTPCrossDeviceName,
flag_descriptions::kWebOTPCrossDeviceDescription, kOsAll,
FEATURE_VALUE_TYPE(kWebOTPCrossDevice)},
{"fractional-scroll-offsets",
flag_descriptions::kFractionalScrollOffsetsName,
flag_descriptions::kFractionalScrollOffsetsDescription, kOsAll,
Expand Down
5 changes: 0 additions & 5 deletions chrome/browser/flag-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -5489,11 +5489,6 @@
// removed if and when we add it as a UI setting (crbug.com/817814).
"expiry_milestone": -1
},
{
"name": "sms-receiver-cross-device",
"owners": [ "goto", "yigu", "web-identity@google.com" ],
"expiry_milestone": 96
},
{
"name": "snooping-protection",
"owners": [ "martis", "charleszhao", "napper" ],
Expand Down
4 changes: 0 additions & 4 deletions chrome/browser/flag_descriptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2373,10 +2373,6 @@ const char kSmoothScrollingName[] = "Smooth Scrolling";
const char kSmoothScrollingDescription[] =
"Animate smoothly when scrolling page content.";

const char kWebOTPCrossDeviceName[] = "WebOTP Cross Device";
const char kWebOTPCrossDeviceDescription[] =
"Enable the WebOTP API to work across devices";

const char kSplitCacheByNetworkIsolationKeyName[] = "HTTP Cache Partitioning";
const char kSplitCacheByNetworkIsolationKeyDescription[] =
"Partitions the HTTP Cache by (top-level site, current-frame site) to "
Expand Down
3 changes: 0 additions & 3 deletions chrome/browser/flag_descriptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -1345,9 +1345,6 @@ extern const char kSiteIsolationOptOutChoiceOptOut[];
extern const char kSmoothScrollingName[];
extern const char kSmoothScrollingDescription[];

extern const char kWebOTPCrossDeviceName[];
extern const char kWebOTPCrossDeviceDescription[];

extern const char kSplitCacheByNetworkIsolationKeyName[];
extern const char kSplitCacheByNetworkIsolationKeyDescription[];

Expand Down

0 comments on commit b5ed51d

Please sign in to comment.