Skip to content

Commit

Permalink
[M103] Fix crash by adding nullptr check for WebContents
Browse files Browse the repository at this point in the history
(cherry picked from commit 5a37dae)

Bug: 1320536
Change-Id: I1fc502e1d1872c9cdcdc2bfb5917cdf891d1050e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3647248
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Asami Doi <asamidoi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Asami Doi <asamidoi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003003}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3676660
Cr-Commit-Position: refs/branch-heads/5060@{#626}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
  • Loading branch information
d0iasm authored and Chromium LUCI CQ committed Jun 7, 2022
1 parent df62a2f commit b65394d
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions chrome/browser/ui/omnibox/chrome_omnibox_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,14 @@ void ChromeOmniboxClient::OnURLOpenedFromOmnibox(OmniboxLog* log) {
// values (kHitFinished, kUnused, kCancelled) are recorded in
// PrerenderManager.
content::WebContents* web_contents = controller_->GetWebContents();
auto* prerender_manager = PrerenderManager::FromWebContents(web_contents);
if (!prerender_manager ||
!prerender_manager->HasSearchResultPagePrerendered()) {
base::UmaHistogramEnumeration(
internal::kHistogramPrerenderPredictionStatusDefaultSearchEngine,
PrerenderPredictionStatus::kNotStarted);
if (web_contents) {
auto* prerender_manager = PrerenderManager::FromWebContents(web_contents);
if (!prerender_manager ||
!prerender_manager->HasSearchResultPagePrerendered()) {
base::UmaHistogramEnumeration(
internal::kHistogramPrerenderPredictionStatusDefaultSearchEngine,
PrerenderPredictionStatus::kNotStarted);
}
}

predictors::AutocompleteActionPredictorFactory::GetForProfile(profile_)
Expand Down

0 comments on commit b65394d

Please sign in to comment.