Skip to content

Commit

Permalink
Update layout tests in devtools/service-work to work with tab target.
Browse files Browse the repository at this point in the history
Bug: 1370050
Change-Id: Ief32a559b451a049a19eba1a9df15558bd9e3167
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4051160
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1075126}
  • Loading branch information
danilsomsikov authored and Chromium LUCI CQ committed Nov 23, 2022
1 parent 0e88067 commit b7dff48
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Expand Up @@ -15,7 +15,7 @@

TestRunner.addSniffer(SDK.MainConnection.prototype, 'sendRawMessage', function(messageString) {
var message = JSON.parse(messageString);
if (!message.sessionId)
if (!message.sessionId || message.sessionId === SDK.targetManager.mainFrameTarget().sessionId)
return;
if (messageString.includes('DOM.'))
TestRunner.addResult('DOM-related command should NOT be issued: ' + messageString);
Expand Down
Expand Up @@ -18,7 +18,7 @@
targetAdded: function(target) {
TestRunner.addResult('Target added: ' + target.name() + '; type: ' + target.type());
if (target.type() === SDK.Target.Type.ServiceWorker) {
var serviceWorkerManager = SDK.targetManager.mainTarget().model(SDK.ServiceWorkerManager);
var serviceWorkerManager = SDK.targetManager.mainFrameTarget().model(SDK.ServiceWorkerManager);
// Allow agents to do rountrips.
TestRunner.deprecatedRunAfterPendingDispatches(function() {
for (var registration of serviceWorkerManager.registrations().values())
Expand Down

0 comments on commit b7dff48

Please sign in to comment.