[iOS][Toolbar][119] Log selected omnibox position

Log the selected omnibox position when starting the app.

(cherry picked from commit 00d3514)

Bug: 1496338
Change-Id: Ie00a1b13f9177311ee4875dcd6827eafd6809bf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4979887
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Christian Xu <christianxu@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Christian Xu <christianxu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1216089}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4987636
Reviewed-by: Erhu Akpobaro <eakpobaro@google.com>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/branch-heads/6045@{#1289}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}

ios/chrome/browser/ui/toolbar/public/omnibox_position_metrics.h

@@ -9,6 +9,10 @@
 // This is used to measure the population for each omnibox position.
 extern const char kOmniboxSteadyStatePositionAtStartup[];
 
+// Logs the selected steady state (unfocused) omnibox position when starting the
+// app. This only logged when the position is user selected.
+extern const char kOmniboxSteadyStatePositionAtStartupSelected[];
+
 // Enum for the IOS.Omnibox.SteadyStatePosition histogram.
 // Keep in sync with "OmniboxPositionType"
 // in src/tools/metrics/histograms/enums.xml.

ios/chrome/browser/ui/toolbar/public/omnibox_position_metrics.mm

@@ -7,6 +7,9 @@
 const char kOmniboxSteadyStatePositionAtStartup[] =
     "IOS.Omnibox.SteadyStatePositionAtStartup";
 
+const char kOmniboxSteadyStatePositionAtStartupSelected[] =
+    "IOS.Omnibox.SteadyStatePositionAtStartup.Selected";
+
 const char kOmniboxDeviceSwitcherResultAtStartup[] =
     "IOS.Omnibox.DeviceSwitcherResult.AtStartup";
 

ios/chrome/browser/ui/toolbar/toolbar_mediator.mm

@@ -446,6 +446,11 @@ - (void)logOmniboxPosition {
                                            : OmniboxPositionType::kTop;
     base::UmaHistogramEnumeration(kOmniboxSteadyStatePositionAtStartup,
                                   positionType);
+
+    if (self.prefService->GetUserPrefValue(prefs::kBottomOmnibox)) {
+      base::UmaHistogramEnumeration(
+          kOmniboxSteadyStatePositionAtStartupSelected, positionType);
+    }
   });
 }
 

tools/metrics/histograms/metadata/ios/histograms.xml

@@ -1675,6 +1675,16 @@ chromium-metrics-reviews@google.com.
   </summary>
 </histogram>
 
+<histogram name="IOS.Omnibox.SteadyStatePositionAtStartup.Selected"
+    enum="OmniboxPositionType" expires_after="2024-01-28">
+  <owner>christianxu@chromium.org</owner>
+  <owner>bling-team@google.com</owner>
+  <summary>
+    Logs the selected steady state (unfocused) omnibox position when starting
+    the app. This only logged when the position is user selected.
+  </summary>
+</histogram>
+
 <histogram name="IOS.Omnibox.SuggestionsListScrolled.{PageClass}"
     enum="Boolean" expires_after="2024-01-31">
   <owner>christianxu@chromium.org</owner>