-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[M115] Repro and fix out of bounds crash
The invariant that size_limit_ never exceed bid_states_.size() was broken when a bid failed due to a load failure (script fails to load), leading to the bounds check in the bid_states_ vector crashing the browser process during ApplySizeLimitAndSort(). ***M115 note***: I also cherry-pick one line from crrev.com/c/4570424 to fix test failures with dangling pointers, since that CL landed after the M115 branch. (cherry picked from commit f738063) Fixed: 1451572 Change-Id: I98d809d50f3aeb00840aabfba8bf925db9e05f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609062 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by: Russ Hamilton <behamilton@google.com> Cr-Original-Commit-Position: refs/heads/main@{#1156509} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4605465 Cr-Commit-Position: refs/branch-heads/5790@{#797} Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
- Loading branch information
Showing
3 changed files
with
57 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters