Skip to content

Commit

Permalink
[iOS] Add about flag entry for notes for passwords
Browse files Browse the repository at this point in the history
Bug: 1414897
Change-Id: I05cb991db77562f3c9304069379510de16946c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4270631
Commit-Queue: Rafał Godlewski <rgod@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1107378}
  • Loading branch information
rgod authored and Chromium LUCI CQ committed Feb 20, 2023
1 parent 4fcedcf commit ba72acf
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion chrome/browser/flag-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -5613,7 +5613,7 @@
},
{
"name": "password-notes",
"owners": ["mamir", "derinel@google.com"],
"owners": ["mamir", "derinel@google.com", "rgod@google.com"],
"expiry_milestone": 114
},
{
Expand Down
3 changes: 3 additions & 0 deletions ios/chrome/browser/flags/about_flags.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1355,6 +1355,9 @@
flag_descriptions::kIOSCustomBrowserEditMenuName,
flag_descriptions::kIOSCustomBrowserEditMenuDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(kIOSCustomBrowserEditMenu)},
{"password-notes", flag_descriptions::kPasswordNotesWithBackupName,
flag_descriptions::kPasswordNotesWithBackupDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(syncer::kPasswordNotesWithBackup)},
};

bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) {
Expand Down
4 changes: 4 additions & 0 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -716,6 +716,10 @@ const char kOptimizationTargetPredictionDescription[] =
const char kOptimizationTargetPredictionName[] =
"Enables usage of optimization guide TFLite models.";

const char kPasswordNotesWithBackupName[] = "Password notes in settings";
const char kPasswordNotesWithBackupDescription[] =
"Enables a note section for each password in the settings page.";

const char kPasswordReuseDetectionName[] =
"PhishGuard password reuse detection";
const char kPasswordReuseDetectionDescription[] =
Expand Down
5 changes: 5 additions & 0 deletions ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,11 @@ extern const char kOneTapForMapsDescription[];
extern const char kOptimizationTargetPredictionDescription[];
extern const char kOptimizationTargetPredictionName[];

// Title and description for the flag to enable adding notes to password in
// settings.
extern const char kPasswordNotesWithBackupName[];
extern const char kPasswordNotesWithBackupDescription[];

// Title and description for the flag to enable PhishGuard password reuse
// detection.
extern const char kPasswordReuseDetectionName[];
Expand Down

0 comments on commit ba72acf

Please sign in to comment.