Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GeolocationManager is owned by ShellBrowserMainParts on iOS and shell_browser_main_parts_ios.mm is introduced to implement GetGeolocationManager() method so that ShellContentBrowserClient can get GeolocationManager from it. `NSLocationWhenInUseUsageDescription` permission is added for ContentShell on IOS to ask Geolocation permission. If `kMacCoreLocationBackend` is enabled, it would work with CoreLocation.framework on iOS as system LocationProvider Bug: 1421221 Change-Id: Id7e8e382c8537238811b6ce05656bfd774258471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4494918 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#1146889}
- Loading branch information
1 parent
573bfb2
commit bb75cae
Showing
8 changed files
with
66 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright 2023 The Chromium Authors | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
#include "content/shell/browser/shell_browser_main_parts.h" | ||
|
||
#include "services/device/public/cpp/geolocation/system_geolocation_source_mac.h" | ||
|
||
#if !defined(__has_feature) || !__has_feature(objc_arc) | ||
#error "This file requires ARC support." | ||
#endif | ||
|
||
namespace content { | ||
|
||
device::GeolocationManager* ShellBrowserMainParts::GetGeolocationManager() { | ||
if (!geolocation_manager_) { | ||
geolocation_manager_ = | ||
device::SystemGeolocationSourceMac::CreateGeolocationManagerOnMac(); | ||
} | ||
return geolocation_manager_.get(); | ||
} | ||
|
||
} // namespace content |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters