-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[StartTablet] Fix the interval padding of MVT on tablets.
This is a follow up of CL: https://crrev.com/c/4479149. This change fixes the issue by incorporating the default calculation method when the interval padding of MVT, determined by the specifications, is either excessively large or too small. Otherwise Chrome would crash as the calculated interval padding is smaller than the min value. The edge margin of MVT element and the top and bottom margin of the single tab card are also changed in this CL according to the new spec. Additionally, a range for the asserting values in the MVT-related tests has been included. See the updated screenshots: https://docs.google.com/document/d/1u1DKlofkFlEZyXzZkpRVR1XZurxp-ZRkvBQB9t5GoKw/edit?usp=sharing&resourcekey=0-bX_lfc8wUp4iPK-iIYN1vQ Bug: 1446043, 1416536 Change-Id: I54554edaff0b3437a676133fce7a9aa3e9e61d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4542600 Commit-Queue: Xinyi Ji <xinyiji@chromium.org> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1148154}
- Loading branch information
Xinyi Ji
authored and
Chromium LUCI CQ
committed
May 23, 2023
1 parent
e4ff999
commit c184bda
Showing
7 changed files
with
89 additions
and
61 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters