Skip to content

Commit

Permalink
[tools/perf] Fix speedometer source for v8 study
Browse files Browse the repository at this point in the history
Switch to timeseries reported under 'Speedometer2' test case, while
we investigate why the summary metric (with no test case) is no longer
reported.

Bug: 994170
Change-Id: I9c11f9070406e9638bb9d433133a7016c31f97cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755982
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#687222}
  • Loading branch information
perezju authored and Commit Bot committed Aug 15, 2019
1 parent 75e8611 commit c1d8fc4
Showing 1 changed file with 20 additions and 14 deletions.
34 changes: 20 additions & 14 deletions tools/perf/cli_tools/soundwave/studies/v8_study.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,22 @@
'v8.browsing_mobile': ['Total:duration', 'V8-Only:duration']
}

BENCHMARK_TEST_SUITES = {
'speedometer2': ['RunsPerMinute'],
'octane': ['Total.Score'],
'jetstream' : ['Score']
}
PRESS_BENCHMARKS = [
{
'test_suite': 'speedometer2',
'measurement': 'RunsPerMinute',
'test_case': 'Speedometer2'
},
{
'test_suite': 'octane',
'measurement': 'Total.Score',
},
{
'test_suite': 'jetstream',
'measurement': 'Score',
}
]


def GetV8BrowsingMobile():
# The describe API doesn't currently work with v8.browsing_mobile, so use
Expand Down Expand Up @@ -54,15 +65,10 @@ def IterTestPaths():
page_category = '_'.join(test_case_parts[0:2])

for measurement in measurements:
# The v2 API doesn't support v8.browsing_mobile, so fall back on the v1
# API for now.
# The v2 API doesn't support v8.browsing_mobile, so fall back on the
# v1 API for now.
yield '/'.join(
[bot_path, test_suite, measurement, page_category, page])

for test_suite, measurements in BENCHMARK_TEST_SUITES.iteritems():
for measurement in measurements:
yield timeseries.Key(
test_suite=test_suite,
measurement=measurement,
bot=bot,
test_case='')
for series in PRESS_BENCHMARKS:
yield timeseries.Key.FromDict(series, bot=bot)

0 comments on commit c1d8fc4

Please sign in to comment.