-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean up synchronous parser virtual suite and expectations
It was noted [1] that the synchronous_html_parser virtual suite was the single most expensive virtual suite, in terms of number of tests run. This CL removes some folders within which there don't currently appear to be any failures. It also moves some of the lines around in TestExpectations to group all of the synchronous parser failures (back) together. Several virtual suite test folders were removed, all of which pass all tests. With one exception, fast/css, which had 3 failures. One was related to the TablesNG work, and I believe unrelated. The other two pass locally for me. I think perhaps they're slightly flaky, but not due to a bug in the synchronous parser. So I decided to remove fast/css to avoid the overhead, for not much/any benefit. [1] https://docs.google.com/spreadsheets/d/1Ehie7RKzTIoHfWbIDGCaeFIqVAci9blSYg2-0VHDfc8/edit#gid=101127889 Bug: 901056 Change-Id: Id82efb1c46a6c4d1105a5c512c1452270db41480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3072839 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#909025}
- Loading branch information
Mason Freed
authored and
Chromium LUCI CQ
committed
Aug 5, 2021
1 parent
49b093a
commit c24b2be
Showing
3 changed files
with
19 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters