-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[headless/m109] Improved Simple CDP Client callback handling.
Previous implementation of the asynchronous callbacks posted a task for each result and event which is suboptimal. This CL changes logic so that all the result and event callbacks are called from a single task posted on the browser UI thread. Drive by: fixed occasional use-after-move in event handler. (cherry picked from commit 3acd45e) Bug: 1382993 Change-Id: I031044a5bfdaab2b88455d1649f53e4adf053140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4026625 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1071300} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4035384 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/branch-heads/5414@{#142} Cr-Branched-From: 4417ee5-refs/heads/main@{#1070088}
- Loading branch information
Peter Kvitek
authored and
Chromium LUCI CQ
committed
Nov 18, 2022
1 parent
30eccb5
commit c2d40e2
Showing
6 changed files
with
26 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
include_rules = [ | ||
"+content/public/browser", | ||
"+content/public/test", | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters