Skip to content

Commit

Permalink
Fix new wpt failures
Browse files Browse the repository at this point in the history
1) Don't save border-box when it's default value.

2) Fix wpt test to accept both normalized and unnormalized path.

Fixed: 1455148
Change-Id: I99b62261f0e567af947274d939ef90c4e0bc904e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4614757
Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1158758}
  • Loading branch information
danielsakhapov authored and Chromium LUCI CQ committed Jun 16, 2023
1 parent f9e8d33 commit c702f93
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 114 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6652,7 +6652,9 @@ CSSValue* ConsumeOffsetPath(CSSParserTokenRange& range,
if (offset_path) {
list->Append(*offset_path);
}
if (coord_box) {
if (!offset_path ||
(coord_box && To<CSSIdentifierValue>(coord_box)->GetValueID() !=
CSSValueID::kBorderBox)) {
list->Append(*coord_box);
}

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@
test_computed_value("offset-path", "inset(10% 20% 30% 40%) border-box", "inset(10% 20% 30% 40%)");
test_computed_value("offset-path", "fill-box ellipse(at 50% 60%)", "ellipse(at 50% 60%) fill-box");
test_computed_value("offset-path", "ray(0deg) stroke-box");
test_computed_value("offset-path", 'path("m 20 0 h -100") view-box');
// Mentionted above above.
test_computed_value("offset-path", 'path("m 20 0 h -100") view-box', [
'path("M 20 0 H -80") view-box',
'path("m 20 0 h -100") view-box'
]);
</script>
</body>
</html>

This file was deleted.

0 comments on commit c702f93

Please sign in to comment.