Almanac: Enable the migration flag by default

The migration is code-complete and launch-approved so we can turn on the
flag by default.

Bug: b/296157719
Change-Id: I6db7ca5a5281997876c86f8e10e8f6fb4d606f4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935738
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Auto-Submit: Elitsa Bankova <elitsa@google.com>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1209970}

chrome/browser/apps/app_discovery_service/almanac_fetcher.cc

@@ -109,9 +109,12 @@ base::CallbackListSubscription AlmanacFetcher::RegisterForAppUpdates(
 void AlmanacFetcher::GetIcon(const std::string& app_id,
                              int32_t size_hint_in_dip,
                              GetIconCallback callback) {
-  if (!icon_cache_) {
+  // Do not use the icon cache if the environment isn't setup correctly.
+  if (!icon_cache_ || !(google_apis::IsGoogleChromeAPIKeyUsed() ||
+                        skip_api_key_check_for_testing)) {
     std::move(callback).Run(gfx::ImageSkia(),
                             DiscoveryError::kErrorRequestFailed);
+    return;
   }
   // We ignore the size as it's hard-coded to kAppIconDimension in:
   // //chrome/browser/ash/app_list/search/common/icon_constants.h

chrome/browser/apps/app_discovery_service/app_discovery_service.cc

@@ -13,7 +13,7 @@ namespace apps {
 
 BASE_FEATURE(kAlmanacGameMigration,
              "AlmanacGameMigration",
-             base::FEATURE_DISABLED_BY_DEFAULT);
+             base::FEATURE_ENABLED_BY_DEFAULT);
 
 AppDiscoveryService::AppDiscoveryService(Profile* profile)
     : app_fetcher_manager_(std::make_unique<AppFetcherManager>(profile)) {}