Skip to content

Commit

Permalink
Revert "weblayer: removes weblayer tests from running on waterfall"
Browse files Browse the repository at this point in the history
This reverts commit 9db96ee.

Reason for revert: this breaks the clank official build, see
crbug.com/1368464 for details.

Original change's description:
> weblayer: removes weblayer tests from running on waterfall
>
> As WebLayer has been deprecated we no longer need to run the tests for
> it. This patch removes the tests (as well as perf tests).
> weblayer-shell is still built, but the tests are no longer built
> and/or run.
>
> Change-Id: I40a4c5d739f404bcf5744219ef6b53a2dbe4226f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3914340
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Rakib Hasan <rmhasan@google.com>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1051332}

(cherry picked from commit 56890ce)

Change-Id: Ib3fc954ec793b97326e94fc07e8f7687f003213f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3921779
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: James Lee <ljjlee@google.com>
Auto-Submit: James Lee <ljjlee@google.com>
Owners-Override: James Lee <ljjlee@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1051785}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3923596
Owners-Override: Krishna Govind <govind@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5326@{#5}
Cr-Branched-From: 1f40050-refs/heads/main@{#1051738}
  • Loading branch information
James Lee authored and Krishna Govind committed Sep 28, 2022
1 parent bdcd251 commit cade232
Show file tree
Hide file tree
Showing 23 changed files with 17,320 additions and 7,222 deletions.
12 changes: 11 additions & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,17 @@ group("gn_all") {
}

if (is_win || is_linux || is_android) {
deps += [ "//weblayer/shell:weblayer_shell" ]
deps += [
"//weblayer/shell:weblayer_shell",
"//weblayer/test:weblayer_browsertests",
"//weblayer/test:weblayer_unittests",
]
if (is_android) {
deps += [
"//weblayer/browser/android/javatests:weblayer_instrumentation_test_apk",
"//weblayer/browser/java:weblayer_junit_tests",
]
}
}

if (!is_ios && !is_android) {
Expand Down
3 changes: 3 additions & 0 deletions docs/speed/perf_lab_platforms.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,13 @@
* [android-pixel2-perf](https://ci.chromium.org/p/chrome/builders/ci/android-pixel2-perf): Android OPM1.171019.021.
* [android-pixel2-perf-calibration](https://ci.chromium.org/p/chrome/builders/ci/android-pixel2-perf-calibration): Android OPM1.171019.021.
* [android-pixel2-perf-pgo](https://ci.chromium.org/p/chrome/builders/ci/android-pixel2-perf-pgo): Android OPM1.171019.021.
* [android-pixel2_weblayer-perf](https://ci.chromium.org/p/chrome/builders/ci/android-pixel2_weblayer-perf): Android OPM1.171019.021.
* [android-pixel2_webview-perf](https://ci.chromium.org/p/chrome/builders/ci/android-pixel2_webview-perf): Android OPM1.171019.021.
* [android-pixel2_webview-perf-pgo](https://ci.chromium.org/p/chrome/builders/ci/android-pixel2_webview-perf-pgo): Android OPM1.171019.021.
* [android-pixel4-perf](https://ci.chromium.org/p/chrome/builders/ci/android-pixel4-perf): Android R.
* [android-pixel4-perf-pgo](https://ci.chromium.org/p/chrome/builders/ci/android-pixel4-perf-pgo): Android R.
* [android-pixel4_weblayer-perf](https://ci.chromium.org/p/chrome/builders/ci/android-pixel4_weblayer-perf): Android R.
* [android-pixel4_weblayer-perf-pgo](https://ci.chromium.org/p/chrome/builders/ci/android-pixel4_weblayer-perf-pgo): Android R.
* [android-pixel4_webview-perf](https://ci.chromium.org/p/chrome/builders/ci/android-pixel4_webview-perf): Android R.
* [android-pixel4a_power-perf](https://ci.chromium.org/p/chrome/builders/ci/android-pixel4a_power-perf): Android QD4A.200102.001.A1.
* [android-pixel4a_power-perf-pgo](https://ci.chromium.org/p/chrome/builders/ci/android-pixel4a_power-perf-pgo): Android QD4A.200102.001.A1.
Expand Down

0 comments on commit cade232

Please sign in to comment.