Skip to content

Commit

Permalink
[M115][Branch Gardener]Disable flaky FencedFrameInThreatDetails test.
Browse files Browse the repository at this point in the history
The test is flaking on Lacros builds. Disable it until a long term
solution for the test is figured out.

(cherry picked from commit 2a525ab)

Bug: 1445499
Change-Id: I1ee6d87924b0bc6b40414e9ff07530179ebb8e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4568531
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Liam Brady <lbrady@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1149741}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598681
Auto-Submit: Elaine Chien <elainechien@chromium.org>
Owners-Override: Elaine Chien <elainechien@google.com>
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/branch-heads/5790@{#471}
Cr-Branched-From: 1d71a33-refs/heads/main@{#1148114}
  • Loading branch information
Liam Brady authored and Chromium LUCI CQ committed Jun 7, 2023
1 parent cddf033 commit cb9d6a0
Showing 1 changed file with 2 additions and 1 deletion.
Expand Up @@ -3376,8 +3376,9 @@ IN_PROC_BROWSER_TEST_P(SafeBrowsingFencedFrameBrowserTest, UnsafeFencedFrame) {
}

// This test is modeled after IframeOptInAndReportThreatDetails above.
// TODO(https://crbug.com/1445499): Flaky
IN_PROC_BROWSER_TEST_P(SafeBrowsingFencedFrameBrowserTest,
FencedFrameInThreatDetails) {
DISABLED_FencedFrameInThreatDetails) {
SetExtendedReportingPrefForTests(browser()->profile()->GetPrefs(), true);
const bool expect_threat_details =
SafeBrowsingBlockingPage::ShouldReportThreatDetails(GetThreatType());
Expand Down

0 comments on commit cb9d6a0

Please sign in to comment.