-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement basic PIN dialog on SAML page
This CL builds the missing integration between the C++ code (starting from the handler of the PIN requests made by extensions) and the JavaScript code on the SAML sign-in page: * dynamically enabling/disabling this UI when the SAML sign-in begins/ends; * sending the PIN request parameters from C++ to JS; * replying with the entered PIN from JS to C++. The proper error displaying and other UI improvements will be done in follow-up CLs. Bug: 964069 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, start logging in using a SAML account that uses smart card authentication, check that the PIN dialog appears on top of the SAML page, enter the smart card PIN, check that the login completes Change-Id: I95c2d5e5110a967ca6b7d8f957bbc8422f62d758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742233 Reviewed-by: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#686151}
- Loading branch information
Maksim Ivanov
authored and
Commit Bot
committed
Aug 12, 2019
1 parent
afda951
commit cbbb33c
Showing
5 changed files
with
220 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.