Skip to content

Commit

Permalink
Disable sending KeyUpdates by default.
Browse files Browse the repository at this point in the history
68df3af was intended to find buggy
servers that don't implement TLS 1.3 KeyUpdate correctly, and it didn't
take long to find some (see bug). This change disables sending
KeyUpdates by default until we've figured out those sites.

TBR=davidben@chromium.org

Bug: 923685
Change-Id: I44968fa85b2b92e18579e7d0fbd13b4b93ecffff
Reviewed-on: https://chromium-review.googlesource.com/c/1424419
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624492}
  • Loading branch information
Adam Langley authored and Commit Bot committed Jan 20, 2019
1 parent 9d6cc12 commit cee722a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/base/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const base::Feature kSplitCacheByTopFrameOrigin{
"SplitCacheByTopFrameOrigin", base::FEATURE_DISABLED_BY_DEFAULT};

const base::Feature kTLS13KeyUpdate{"TLS13KeyUpdate",
base::FEATURE_ENABLED_BY_DEFAULT};
base::FEATURE_DISABLED_BY_DEFAULT};

} // namespace features
} // namespace net

0 comments on commit cee722a

Please sign in to comment.