Skip to content

Commit

Permalink
[wasm] Enable and fix wasm exceptions WPTs
Browse files Browse the repository at this point in the history
For most tests, expectations were deleted since the tests now pass.

The getArg test was corrected to match the spec:
https://webassembly.github.io/exception-handling/js-api/index.html#dom-exception-getarg

The tag type test had its expectations updated, but is still
(incorrectly) failing because the test also depends on the not-yet-shipped
type reflection proposal. Updated the spec bug to bring this conversation
back to the spec (WebAssembly/exception-handling#172).

Bug: v8:11992
Change-Id: I979a9eb00219e0b9515d43bbeff6f80ac57df7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3972061
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1063368}
  • Loading branch information
ajklein authored and Chromium LUCI CQ committed Oct 25, 2022
1 parent 0752040 commit cf0b4ca
Show file tree
Hide file tree
Showing 23 changed files with 7 additions and 147 deletions.
4 changes: 0 additions & 4 deletions third_party/blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -5184,10 +5184,6 @@ crbug.com/1084256 [ Linux ] http/tests/misc/insert-iframe-into-xml-document-befo
crbug.com/1084256 [ Mac ] http/tests/misc/insert-iframe-into-xml-document-before-xsl-transform.html [ Failure Pass ]
crbug.com/1084276 [ Mac ] http/tests/security/offscreencanvas-placeholder-read-blocked-no-crossorigin.html [ Crash Failure Pass ]

# Temporarily disabled to land the new wasm exception handling JS API
crbug.com/v8/11992 external/wpt/wasm/jsapi/exception/* [ Skip ]
crbug.com/v8/11992 external/wpt/wasm/jsapi/tag/* [ Skip ]

# Assorted virtual/threaded/.../wpt/scroll-animations tests
crbug.com/1279648 [ Mac ] virtual/threaded/external/wpt/scroll-animations/css/scroll-timeline-default-descriptors-iframe.html [ Failure ]
crbug.com/1279648 virtual/threaded/external/wpt/scroll-animations/css/scroll-timeline-default-descriptors-quirks-mode.html [ Failure ]
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test(() => {
test(() => {
const tag = new WebAssembly.Tag({ parameters: [] });
const exn = new WebAssembly.Exception(tag, []);
assert_throws_js(TypeError, () => exn.getArg(tag, 1));
assert_throws_js(RangeError, () => exn.getArg(tag, 1));
}, "Index out of bounds");

test(() => {
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
This is a testharness.js-based test.
FAIL [] WebAssembly.Tag is not a constructor
FAIL [i32 i64] WebAssembly.Tag is not a constructor
FAIL [i32 i64 f32 f64] WebAssembly.Tag is not a constructor
FAIL [] tag.type is not a function
FAIL [i32 i64] tag.type is not a function
FAIL [i32 i64 f32 f64] tag.type is not a function
Harness: the test ran to completion.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
This is a testharness.js-based test.
FAIL [] WebAssembly.Tag is not a constructor
FAIL [i32 i64] WebAssembly.Tag is not a constructor
FAIL [i32 i64 f32 f64] WebAssembly.Tag is not a constructor
FAIL [] tag.type is not a function
FAIL [i32 i64] tag.type is not a function
FAIL [i32 i64 f32 f64] tag.type is not a function
Harness: the test ran to completion.

This file was deleted.

This file was deleted.

0 comments on commit cf0b4ca

Please sign in to comment.