Skip to content

Commit

Permalink
[merge m110] Remove DumpWithoutCrashing when a feature is accessed to…
Browse files Browse the repository at this point in the history
…o early.

This is a temporary change to be merged to M110 to reduce the crash
volume while a fix for crbug.com/1392145 is prepared. It will be
reverted as soon as https://crrev.com/c/4188827 lands.

(cherry picked from commit 77537ff)

Bug: 1386223
Change-Id: I9640679759bb5aff0d63cc624ce446e56afd366d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188993
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Francois Pierre Doray <fdoray@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1097433}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200967
Commit-Queue: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/branch-heads/5481@{#728}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
  • Loading branch information
fdoray authored and Chromium LUCI CQ committed Jan 27, 2023
1 parent 51146e8 commit cfc8c7a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion base/feature_list.cc
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ class EarlyFeatureAccessTracker {
// TODO(crbug.com/1383852): When we believe that all early accesses have
// been fixed, remove this base::debug::DumpWithoutCrashing() and change the
// above DCHECK to a CHECK.
base::debug::DumpWithoutCrashing();

// The following line is commented to reduce the crash volume while a fix
// for crbug.com/1392145 is prepared.
// base::debug::DumpWithoutCrashing();
#endif // !BUILDFLAG(IS_IOS) && !BUILDFLAG(IS_ANDROID) &&
// !BUILDFLAG(IS_CHROMEOS)
}
Expand Down

0 comments on commit cfc8c7a

Please sign in to comment.